-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assertion for IPv4 check in verify settings #8946
Conversation
|
Hi @Citrullin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
That does the job. Since there are also some local legacy IPs, I guess this should work just as it did before, while fixing the issue for IPv6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, new one is much better.
just few comments.
Co-authored-by: Kenichi Omichi <ken1ohmichi@gmail.com>
Thanks for updating. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Citrullin Thank you for the update and the PR 🙇
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Citrullin, floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Installation on IPv6 only nodes fails, because of an IPv4 assertion.
Is needed to run kubespray for IPv6 only nodes.
Special notes for your reviewer:
All nodes have to IPv6 only.
Does this PR introduce a user-facing change?: