-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsafe_show_logs switch #9164
Add unsafe_show_logs switch #9164
Conversation
Hi @ErikJiang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I would even enable this in the default CI settings since we sometimes have download failures due to external factors. |
@cristicalin 😁 done. |
Hi @ErikJiang , please rebase this PR on current master branch to include the CI fix in #9175 |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@cristicalin 😅 after rebase, there are new errors. |
Hi @ErikJiang , I cleaned up the ElastX environment and relaunched your CI pipeline, hopefully this time it goes all the way through. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, ErikJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang bo.jiang@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
unsafe_show_logs
switch to show more log details, it is helpful for debugging kubespray.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: