Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe_show_logs switch #9164

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Add unsafe_show_logs switch #9164

merged 1 commit into from
Aug 17, 2022

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Aug 11, 2022

Signed-off-by: bo.jiang bo.jiang@daocloud.io

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add unsafe_show_logs switch to show more log details, it is helpful for debugging kubespray.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add unsafe_show_logs switch to show more log details (default to false, same as previous behavior)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ErikJiang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2022
@liupeng0518
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2022
@cristicalin
Copy link
Contributor

I would even enable this in the default CI settings since we sometimes have download failures due to external factors.

@ErikJiang
Copy link
Member Author

ErikJiang commented Aug 13, 2022

I would even enable this in the default CI settings since we sometimes have download failures due to external factors.

@cristicalin 😁 done.

@cristicalin
Copy link
Contributor

Hi @ErikJiang , please rebase this PR on current master branch to include the CI fix in #9175

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@ErikJiang
Copy link
Member Author

Hi @ErikJiang , please rebase this PR on current master branch to include the CI fix in #9175

@cristicalin 😅 after rebase, there are new errors.

@cristicalin
Copy link
Contributor

Hi @ErikJiang , I cleaned up the ElastX environment and relaunched your CI pipeline, hopefully this time it goes all the way through.

@cristicalin
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, ErikJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@cyclinder
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9ad2d24 into kubernetes-sigs:master Aug 17, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants