-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubernetes] support 1.24.x #8935
[kubernetes] support 1.24.x #8935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to mention about the option dynamic_kubelet_configuration
has been removed in the release-note.
/cc @oomichi
@@ -1,4 +1,4 @@ | |||
apiVersion: kubeadm.k8s.io/v1beta2 | |||
apiVersion: kubeadm.k8s.io/v1beta3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consider also renaming the templates files to v1beta3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'm trying to get a CI job failure out of the way first but will do this as well.
/retest |
5da40cb
to
b8cac9c
Compare
8fe14f2
to
d38500f
Compare
926106f
to
39ccc3a
Compare
* use new artifact release name * enable cri-dockerd dual setack support if enable_dual_stack_networks
…sion deployed with docker as the container_manager
…e the default of 2048
* extra admission controls now don't have a version in their file names eventratelimit.v1beta2.yaml.j2 -> eventratelimit.yaml.j2 * cri_socket variable includes the unix:// prefix to be conformat with upstream
roles/kubernetes/control-plane/templates/kubeadm-config.v1beta3.yaml.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ok let's go! thanks @cristicalin
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes kubernetes 1.24 the new default version, it drops support for 1.21.x and ensures that all supported container managers are still working by pinning cri-dockerd as the replacement for dockershim (see kubernetes/kubernetes@6c6c7e5 for details)
Which issue(s) this PR fixes:
Fixes #8924 #8953
Special notes for your reviewer:
Does this PR introduce a user-facing change?: