-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "openSUSE Tumbleweed" to be run #9072
Conversation
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
The commit 1ce2f04 tried to merge multiple SUSE OS checks including "openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but that was a perfect change. Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it didn't take care of "openSUSE Tumbleweed". Then this adds "openSUSE Tumbleweed" to the OS check.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The commit 1ce2f04 tried to merge multiple SUSE OS checks including
"openSUSE Leap" and "openSUSE Tumbleweed" into a single SUSE, but
that was a perfect change.
Then the commit c16efc9 tried to fix it for "openSUSE Leap", but it
didn't take care of "openSUSE Tumbleweed".
Then this adds "openSUSE Tumbleweed" to the OS check.
Which issue(s) this PR fixes:
Fixes #8977
Does this PR introduce a user-facing change?: