-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rocky Linux 8 support for vagrant and CI #8905
Add Rocky Linux 8 support for vagrant and CI #8905
Conversation
/hold |
bbcc1da
to
48b57f9
Compare
48b57f9
to
5ac65c6
Compare
test-infra/image-builder/roles/kubevirt-images/defaults/main.yml
Outdated
Show resolved
Hide resolved
ba09629
to
e6d1516
Compare
4bd5f01
to
0cb67b9
Compare
0cb67b9
to
00a8b18
Compare
00a8b18
to
8d6d5fe
Compare
/ok-to-test |
8d6d5fe
to
3e2c41b
Compare
I just rebuilt the rocky image but it seems indeed to be missing sudo which is rather odd and should be reported to the rocky team to be fixed. |
3e2c41b
to
c5cced0
Compare
Thank you so much for creating a new image with |
Interesting, the rockylinux8 image doesn't contain
|
c5cced0
to
c232499
Compare
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile.
c232499
to
d4672e0
Compare
@floryut @cristicalin Please take a look at this. Now that works 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Good job @oomichi 🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wake the bot up /ok-to-test |
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile.
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile.
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile.
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile and CI configuration file.
Does this PR introduce a user-facing change?: