Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rocky Linux 8 support for vagrant and CI #8905

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented May 31, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To test Kubespray on Rocky Linux 8 with vagrant, this adds it to the Vagrantfile and CI configuration file.

Does this PR introduce a user-facing change?:

Add Rocky Linux 8 support

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2022
@oomichi oomichi changed the title Add Rocky Linux 8 support for vagrant Add Rocky Linux 8 support for vagrant and CI May 31, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@oomichi
Copy link
Contributor Author

oomichi commented May 31, 2022

+ echo 'Generate current file...'
Generate current file...
+ ./tests/scripts/md-table/main.py
+ echo 'Compare docs/ci.md with actual tests in tests/files/*.yml ...'
Compare docs/ci.md with actual tests in tests/files/*.yml ...
+ cmp docs/ci.md tmp.md
docs/ci.md tmp.md differ: byte 338, line 10

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@oomichi oomichi force-pushed the add-rocky8-vagrant branch 3 times, most recently from ba09629 to e6d1516 Compare June 1, 2022 19:52
@k8s-ci-robot k8s-ci-robot requested a review from floryut June 5, 2022 18:41
@oomichi oomichi force-pushed the add-rocky8-vagrant branch 2 times, most recently from 4bd5f01 to 0cb67b9 Compare June 10, 2022 02:45
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Jun 14, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 14, 2022
@cristicalin
Copy link
Contributor

I just rebuilt the rocky image but it seems indeed to be missing sudo which is rather odd and should be reported to the rocky team to be fixed.
I just patched the image to add the sudo dependency since I don't see any sane system missing sudo but we need to be mindful of this when rebuilding the images or if we do an automated job for it.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Jun 17, 2022

I just rebuilt the rocky image but it seems indeed to be missing sudo which is rather odd and should be reported to the rocky team to be fixed. I just patched the image to add the sudo dependency since I don't see any sane system missing sudo but we need to be mindful of this when rebuilding the images or if we do an automated job for it.

Thank you so much for creating a new image with sudo command @cristicalin 🙏
Let me try kicking the job again.

@oomichi
Copy link
Contributor Author

oomichi commented Jun 17, 2022

Interesting, the rockylinux8 image doesn't contain hostname command also.
That seems super minimum image I never see 😅

TASK [bootstrap-os : Assign inventory name to unconfigured hostnames (non-CoreOS, non-Flatcar, Suse and ClearLinux, non-Fedora)] ***
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/bootstrap-os/tasks/main.yml:55
Friday 17 June 2022  17:27:03 +0000 (0:00:00.901)       0:00:30.946 *********** 
fatal: [instance-2]: FAILED! => {"changed": false, "msg": "Failed to find required executable \"hostname\" in paths: /home/kubespray/.local/bin:/home/kubespray/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"}
fatal: [instance-1]: FAILED! => {"changed": false, "msg": "Failed to find required executable \"hostname\" in paths: /home/kubespray/.local/bin:/home/kubespray/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"}

To test Kubespray on Rocky Linux 8 with vagrant, this adds it to
the Vagrantfile.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Jul 1, 2022

@floryut @cristicalin Please take a look at this. Now that works 😃

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good job @oomichi 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cristicalin
Copy link
Contributor

Wake the bot up

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit f3ea8cf into kubernetes-sigs:master Jul 5, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to
the Vagrantfile.
@oomichi oomichi mentioned this pull request Jul 15, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to
the Vagrantfile.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to
the Vagrantfile.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
To test Kubespray on Rocky Linux 8 with vagrant, this adds it to
the Vagrantfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants