-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vcloud-csi bug related to #9046 #9066
Fix vcloud-csi bug related to #9046 #9066
Conversation
Signed-off-by: yasintahaerol <yasintahaerol@gmail.com>
|
Welcome @yasintahaerol! |
Hi @yasintahaerol. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…er-deployment Signed-off-by: yasintahaerol <yasintahaerol@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@yasintahaerol Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, yasintahaerol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
) * Fix vcloud-csi bug related to kubernetes-sigs#9046 Signed-off-by: yasintahaerol <yasintahaerol@gmail.com> * add supervisor-fss-namespace=kube-system flag to vsphere-csi-controller-deployment Signed-off-by: yasintahaerol <yasintahaerol@gmail.com>
) * Fix vcloud-csi bug related to kubernetes-sigs#9046 Signed-off-by: yasintahaerol <yasintahaerol@gmail.com> * add supervisor-fss-namespace=kube-system flag to vsphere-csi-controller-deployment Signed-off-by: yasintahaerol <yasintahaerol@gmail.com>
) * Fix vcloud-csi bug related to kubernetes-sigs#9046 Signed-off-by: yasintahaerol <yasintahaerol@gmail.com> * add supervisor-fss-namespace=kube-system flag to vsphere-csi-controller-deployment Signed-off-by: yasintahaerol <yasintahaerol@gmail.com>
Signed-off-by: yasintahaerol yasintahaerol@gmail.com
Co-authored-by: eminaktas eminaktas34@gmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
We notice a bug after this pr #9046. We shoud add --supervisor-fss-namespace=kube-system flag to installation. When we did not use this flag we could'not get proper installation.
Which issue(s) this PR fixes:
Fixes #9069
Special notes for your reviewer:
Error:
{"level":"error","time":"2022-07-06T14:00:35.090328906Z","caller":"cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:196","msg":"failed to create CnsVolumeOperationRequest instance vmware-system-csi/delete-da131a33-1b07-42fd-9192-1d80f5c44885 with error: namespaces \"vmware-system-csi\" not found"....
Does this PR introduce a user-facing change?: