-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker option in centos arm64 #9047
Fix docker option in centos arm64 #9047
Conversation
Hi @yankay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
HI @cristicalin @floryut , would you please review the PR. |
9cffb66
to
b04735d
Compare
b04735d
to
26481c5
Compare
/lgtm |
Thanks @yankay ! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @liupeng0518 @cristicalin for the PR review. |
What type of PR is this?
What this PR does / why we need it:
The Docker Option is not work in centos arm64 platform. Because of it use error cgroupdriver.
The code is added in #2168 in 2018. The cgroup driver is cgroupfs in x86 , and systemd in arm64.
And the default docker_cgroup_driver has been to systemd now. It's the same between arm64 and x86 now. So we should remove these code.
I have tested the change in ARM64 machine.
Which issue(s) this PR fixes:
Fixes #9013
Special notes for your reviewer:
Does this PR introduce a user-facing change?: