Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker option in centos arm64 #9047

Conversation

yankay
Copy link
Member

@yankay yankay commented Jul 1, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

The Docker Option is not work in centos arm64 platform. Because of it use error cgroupdriver.

The code is added in #2168 in 2018. The cgroup driver is cgroupfs in x86 , and systemd in arm64.

And the default docker_cgroup_driver has been to systemd now. It's the same between arm64 and x86 now. So we should remove these code.

I have tested the change in ARM64 machine.

Which issue(s) this PR fixes:
Fixes #9013

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix the Centos/RHEL docker installation issue in  ARM64 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yankay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2022
@liupeng0518
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2022
@yankay
Copy link
Member Author

yankay commented Jul 4, 2022

HI @cristicalin @floryut , would you please review the PR.

@yankay yankay force-pushed the fix-docker-option-in-centos-arm64 branch from 9cffb66 to b04735d Compare July 4, 2022 05:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2022
@yankay yankay force-pushed the fix-docker-option-in-centos-arm64 branch from b04735d to 26481c5 Compare July 4, 2022 05:41
@liupeng0518
Copy link
Member

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2022
@cristicalin
Copy link
Contributor

Thanks @yankay !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9ca5632 into kubernetes-sigs:master Jul 5, 2022
@yankay
Copy link
Member Author

yankay commented Jul 6, 2022

Thanks @liupeng0518 @cristicalin for the PR review.

@floryut floryut added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In both centos7/8 arm64 platform, docker.service fail to start
5 participants