Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Rewrite Plugin to CoreDNS/NodelocalDNS #9245

Merged

Conversation

eifelmicha
Copy link
Contributor

@eifelmicha eifelmicha commented Sep 1, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds support for the usage of CoreDNS plugin rewrite: https://coredns.io/plugins/rewrite/
This allows to rewrite for example external domains to internal kubernetes service names before passing the query to upstream dns

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
I did not found an variable for the CoreDNS Cluster IP, therefore i added the standard 10.233.0.3 hardcoded in the examples.

Does this PR introduce a user-facing change?:

Add Support for Rewrite Plugin to CoreDNS/NodelocalDNS

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @eifelmicha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2022
@yankay
Copy link
Member

yankay commented Sep 2, 2022

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@cristicalin
Copy link
Contributor

Thanks @eifelmicha !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, eifelmicha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit be2bfd8 into kubernetes-sigs:master Sep 3, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants