Use 'inventory_hostnames' query for remove-node #8099
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the 'inventory_hostnames' lookup instead of manual splitting
allows us to use ansible patterns ; we are no longer forced to
explicitely spell out hostnames (but doing so still works).
What type of PR is this?
/kind feature
What this PR does / why we need it:
It allows more flexibility for the remove-node.yml playbook. We can use
kube_master[1]
instead of explicitely specifyingmy_kube_master_01
forexample.
Special notes for your reviewer:
This is a draft because the
inventory_hostnames
lookup don't really work properlyuntil this commit
in ansible, which is in ansible 2.11.0. So this is dependant on switching to
ansible 2.11
Does this PR introduce a user-facing change?: