Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'inventory_hostnames' query for remove-node #8099

Closed

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Oct 20, 2021

Using the 'inventory_hostnames' lookup instead of manual splitting
allows us to use ansible patterns ; we are no longer forced to
explicitely spell out hostnames (but doing so still works).

What type of PR is this?

/kind feature

What this PR does / why we need it:

It allows more flexibility for the remove-node.yml playbook. We can use
kube_master[1] instead of explicitely specifying my_kube_master_01 for
example.

Special notes for your reviewer:

This is a draft because the inventory_hostnames lookup don't really work properly
until this commit
in ansible, which is in ansible 2.11.0. So this is dependant on switching to
ansible 2.11

Does this PR introduce a user-facing change?:

Ansible patterns can now be used in the `node` variables for the `remove-node.yml`
playbook.

Using the 'inventory_hostnames' lookup instead of manual splitting
allows us to use ansible patterns ; we are no longer forced to
explicitely spell out hostnames (but doing so still works).
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten October 20, 2021 10:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VannTen
To complete the pull request process, please assign floryut after the PR has been reviewed.
You can assign the PR to them by writing /assign @floryut in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2021
@VannTen
Copy link
Contributor Author

VannTen commented Dec 24, 2021

Superseded by #8334
/close

@k8s-ci-robot
Copy link
Contributor

@VannTen: Closed this PR.

In response to this:

Superseded by #8334
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants