Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify usage of pre-remove role #8334

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Simplify usage of pre-remove role #8334

merged 1 commit into from
Jan 4, 2022

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 24, 2021 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Use builtin task scheduling of ansible (same task on each host)
    instead of manual looping on master

Benefits:

  • One less play in remove-node.yml playbook
  • Parrallel node drain
  • Drain parameters (timeout, grace period, retries,
    allow_ungraceful_removal) can be adjusted separately for each node
    with ansible variables

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

Nodes are now drained in parallel when using the playbook `remove-node.yml`

@VannTen
Simplify usage of pre-remove role
36be290 
- Use builtin task scheduling of ansible (same task on each host)
  instead of manual looping on master

Benefits:
- One less play in remove-node.yml playbook
- Parralel node drain
- Drain parameters (timeout, grace period, retries,
  allow_ungraceful_removal) can be adjusted separately for each node
  with ansible variables
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO December 24, 2021 08:59
@VannTen
Copy link
Contributor Author

VannTen commented Dec 24, 2021

This also accomplishes the same purpose than #8099 without needing ansible 2.11

@VannTen VannTen mentioned this pull request Dec 24, 2021
Closed
@cristicalin
Copy link
Contributor

Nice improvement @VannTen !

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2021
@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2022
@cristicalin
Copy link
Contributor

/cc @floryut - this could make it into 2.18

@floryut
Copy link
Member

floryut commented Jan 4, 2022

/cc @floryut - this could make it into 2.18

Fine by me 👍

floryut
floryut approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@floryut floryut mentioned this pull request Jan 4, 2022
Closed
@k8s-ci-robot k8s-ci-robot merged commit 92f25bf into kubernetes-sigs:master Jan 4, 2022
@floryut floryut mentioned this pull request Jan 4, 2022
Closed
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 6, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@VannTen @sakuraiyuta
Simplify usage of pre-remove role (kubernetes-sigs#8334)
57f9cbc 
- Use builtin task scheduling of ansible (same task on each host)
  instead of manual looping on master

Benefits:
- One less play in remove-node.yml playbook
- Parralel node drain
- Drain parameters (timeout, grace period, retries,
  allow_ungraceful_removal) can be adjusted separately for each node
  with ansible variables
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@VannTen @LuckySB
Simplify usage of pre-remove role (kubernetes-sigs#8334)
e03834a 
- Use builtin task scheduling of ansible (same task on each host)
  instead of manual looping on master

Benefits:
- One less play in remove-node.yml playbook
- Parralel node drain
- Drain parameters (timeout, grace period, retries,
  allow_ungraceful_removal) can be adjusted separately for each node
  with ansible variables
@VannTen VannTen mentioned this pull request Nov 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VannTen @k8s-ci-robot @cristicalin @floryut