Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calico VXLAN offload docs because Calico changed the default value. #9639

Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Jan 5, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Update Calico VXLAN offload docs because Calico changed the default value.
The Calico VXLAN Offload Issue has been fixed at the calico 3.25 & 3.24.5 by projectcalico/calico#6842 , So the kubespray should change the docs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update Calico VXLAN offload docs because Calico changed the default value.

@yankay yankay force-pushed the update-calico-VXLAN-docs branch from 1091df2 to 6d3acd8 Compare January 5, 2023 03:45
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2023
@yankay yankay force-pushed the update-calico-VXLAN-docs branch from 6d3acd8 to e145cb8 Compare January 5, 2023 08:38
@yankay
Copy link
Member Author

yankay commented Jan 6, 2023

HI @floryut , would you please review the PR :-)

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yankay Yes, all good 🙇 thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floryut floryut mentioned this pull request Jan 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 843e908 into kubernetes-sigs:master Jan 6, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants