Disable VXLAN checksum offload by default. #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasaxc
added
cherry-pick-candidate
docs-not-required
marvin-tigera
added
the
release-note-required
fasaxc
force-pushed
the
disable-offload
branch
2 times, most recently
from
934a00b to
517193a
Compare
3 tasks
caseydavenport
approved these changes
Oct 14, 2022
|
To be clear, this disables checksum offload for both VXLAN and IP-IP? Or just VXLAN? |
Reports of the kernel bug being fixed seem to have been greatly exaggerated.
fasaxc
force-pushed
the
disable-offload
branch
from
517193a to
53f3e1b
Compare
|
@remram44 it's VXLAN only, why? |
|
@fasaxc I'm in IPIP mode I've had to disable offloading ( |
|
@remram44 Well, this PR simple defaults that flag to false but I didn't think that had any effect on an IPIP system. |
|
@fasaxc I see this is marked as cherry-pick candidate, is it going to be included in a release in the near future? |
3 tasks
This was referenced Jan 5, 2023
4 tasks
andy108369
added a commit
to andy108369/docs
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reports of the kernel bug being fixed seem to have been greatly exaggerated.
Related issues/PRs
Fixes #4727
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.