-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build e2e requirements for kind deployer #275
build e2e requirements for kind deployer #275
Conversation
Welcome @elieser1101! |
Hi @elieser1101. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Co-authored-by: Mahamed Ali <cy@borg.dev>
it looks correct but I couldn't test it neither will have time soon to do it |
would be a new non blocking e2e test running the above passing be enough to help test this? |
I'm fine with manual testing on this by now, have you verified it works? /approve defer final LGTM to @upodroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feature.
I'll open a new PR and adjust the CI to test kubetest2 kind deployer similar to the GCE one. https://github.com/kubernetes-sigs/kubetest2/blob/master/kubetest2-gce/ci-tests/updown-legacy.sh
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, elieser1101, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This should fix #184
This changes ensures e2e requirements can be found in _rundir/$KUBETEST2_RUN_DIR
as described in
kubetest2/pkg/testers/ginkgo/ginkgo.go
Line 50 in 696b358
I replicatrd the same behavior from https://github.com/kubernetes-sigs/kind/blob/main/hack/ci/e2e-k8s.sh#L72-L86