Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetest2 + kind using binaries from source #277

Merged
merged 1 commit into from
Nov 10, 2024
Merged

kubetest2 + kind using binaries from source #277

merged 1 commit into from
Nov 10, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Nov 5, 2024

Testing changes in #275

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@elieser1101
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@elieser1101: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TerryHowe
TerryHowe approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerryHowe, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a5c39a3 into kubernetes-sigs:master Nov 10, 2024
11 of 12 checks passed
@TerryHowe
Copy link
Member

I assume this will fix CI

@elieser1101 elieser1101 mentioned this pull request Nov 10, 2024
Merged
@upodroid
Copy link
Member Author

I assume this will fix CI

It does but needs more work, I'll follow up in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@aojea aojea Awaiting requested review from aojea

@dims dims Awaiting requested review from dims

Assignees

@TerryHowe TerryHowe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @elieser1101 @k8s-ci-robot @TerryHowe