Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the lock as soon as possible when computing the snapashot for CQ visibility #1098

Closed
mimowo opened this issue Sep 8, 2023 · 2 comments · Fixed by #1124
Closed

Release the lock as soon as possible when computing the snapashot for CQ visibility #1098

mimowo opened this issue Sep 8, 2023 · 2 comments · Fixed by #1124
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Sep 8, 2023

This is a follow up for review remark: https://github.com/kubernetes-sigs/kueue/pull/1069/files/3b1f7c19d16b67a267d30ba8945ae1a3bb2b501e#r1319099583

What would you like to be cleaned:

The sort operation can be done once the lock is released.

Why is this needed:

Improve performance of Kueue by reducing lock contention.

@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 8, 2023
@stuton stuton removed their assignment Sep 18, 2023
@tenzen-y
Copy link
Member

/assign @lowang-bh

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: GitHub didn't allow me to assign the following users: lowang-bh.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lowang-bh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants