release lock as soon as finish using

[lowang-bh]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1098

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	d65b779
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65092e0ebac7fb00081ebad2
😎 Deploy Preview	https://deploy-preview-1124--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Hi @lowang-bh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[trasc]

/lgtm
/asign @mimowo

[trasc]

/ok-to-test

[mimowo]

It looks ok, but I have a slight concern, that if there is a panic thrown between Lock and Unlock the lock will remain. It is usually not an issue if the code in between is very simple (sort of like here), but I have a feeling this code may evolve.

I would suggest to wrap the code into a function call and use Lock / defer Unlock pattern for the duration of the function. This could be either in a named function, like "snapshotQueueData", or an unnamed, like we do for example here:

kueue/client-go/informers/externalversions/factory.go

Lines 148 to 159 in 0ee53de

	informers := func() map[reflect.Type]cache.SharedIndexInformer {
	f.lock.Lock()
	defer f.lock.Unlock()
	informers := map[reflect.Type]cache.SharedIndexInformer{}
	for informerType, informer := range f.informers {
	if f.startedInformers[informerType] {
	informers[informerType] = informer
	}
	}
	return informers
	}()

.

[alculquicondor]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/hold

[alculquicondor]

/lgtm cancel

I'll leave the LGTM to @mimowo

[tenzen-y]

It looks ok, but I have a slight concern, that if there is a panic thrown between Lock and Unlock the lock will remain. It is usually not an issue if the code in between is very simple (sort of like here), but I have a feeling this code may evolve.

I would suggest to wrap the code into a function call and use Lock / defer Unlock pattern for the duration of the function. This could be either in a named function, like "snapshotQueueData", or an unnamed, like we do for example here:

kueue/client-go/informers/externalversions/factory.go

Lines 148 to 159 in 0ee53de

	informers := func() map[reflect.Type]cache.SharedIndexInformer {
	f.lock.Lock()
	defer f.lock.Unlock()
	informers := map[reflect.Type]cache.SharedIndexInformer{}
	for informerType, informer := range f.informers {
	if f.startedInformers[informerType] {
	informers[informerType] = informer
	}
	}
	return informers
	}()

.

It sounds reasonable. The current implementation is a bit dangerous.

[lowang-bh]

It sounds reasonable. The current implementation is a bit dangerous.

Have updated.

[mimowo]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: f13b413e3b02927f9e0217fb3684daae0fabdce0

[mimowo]

/hold cancel