Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test cases are independent #72

Closed
5 tasks
alculquicondor opened this issue Feb 25, 2022 · 9 comments · Fixed by #262 or #538
Closed
5 tasks

Ensure test cases are independent #72

alculquicondor opened this issue Feb 25, 2022 · 9 comments · Fixed by #262 or #538
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@alculquicondor
Copy link
Contributor

In an effort to get a binary that "works", we wrote some tests where a test case depends on the state left by previous test cases.

This is problematic for debugging problems and it tends to lead to a lot of test changes when there is a behavior change or you want to insert a case in the middle of the existing ones.

Places that I'm aware of:

And there are similar situations in the following, but it's more like a single complex test case in each:

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 25, 2022
@ahg-g
Copy link
Contributor

ahg-g commented Mar 9, 2022

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ahg-g:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 9, 2022
@shuheiktgw
Copy link
Contributor

Let me work on this issue!
/assign

@shuheiktgw
Copy link
Contributor

Seems like TestCacheCapacityOperations does not exist anyomre?

@alculquicondor
Copy link
Contributor Author

It's now TestCacheClusterQueueOperations

@shuheiktgw
Copy link
Contributor

shuheiktgw commented May 15, 2022

Looks like the issue with TestCacheCapacityOperations (TestCacheClusterQueueOperations) was already resolved in #133 🙂 Looking into the scheduler integration test

@shuheiktgw
Copy link
Contributor

shuheiktgw commented May 17, 2022

I found the problem with the scheduler integration tests was resolved in #90
I'm looking into snapshot_test.go next

shuheiktgw added a commit to shuheiktgw/kueue that referenced this issue May 24, 2022
shuheiktgw added a commit to shuheiktgw/kueue that referenced this issue May 26, 2022
ahg-g pushed a commit to ahg-g/kueue that referenced this issue Aug 10, 2022
@tenzen-y
Copy link
Member

tenzen-y commented Jan 5, 2023

/reopen
/assign

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: Reopened this issue.

In response to this:

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
5 participants