Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestSnapshot #538

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I refactored tests for the snapshot.

Which issue(s) this PR fixes:

Fixes #72,#269

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 30, 2023
@tenzen-y tenzen-y changed the title Refactor TestSnapshot [WIP] Refactor TestSnapshot Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@tenzen-y
Copy link
Member Author

I adapt the test to preemption.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023
@tenzen-y tenzen-y changed the title [WIP] Refactor TestSnapshot Refactor TestSnapshot Feb 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Feb 3, 2023

This PR is ready for review.
PTAL.

/assign @alculquicondor

{
Name: "demand",
Min: 100_000,
wantSnapshot: Snapshot{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can do

wantSnapshot: func() Snapshot {
  cohort := .....
  return Snapshot{
  }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ResourceFlavors: map[string]*kueue.ResourceFlavor{},
},
},
"clusterQueues": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

independent clusterQueues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

{
ObjectMeta: metav1.ObjectMeta{
Name: "with-preemption",
"workloads": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just merge this one with the test case above titled "clusterQueues"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alculquicondor
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 5d67803
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/63e1ae88a0cccc00088def2e

@tenzen-y
Copy link
Member Author

tenzen-y commented Feb 7, 2023

@alculquicondor I addressed your comments. PTAL.

@alculquicondor
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8bdef2b into kubernetes-sigs:main Feb 7, 2023
@tenzen-y tenzen-y deleted the refactor-snapshot-test branch February 7, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure test cases are independent
3 participants