Refactor TestSnapshot #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
I adapt the test to preemption. |
k8s-ci-robot
added
the
needs-rebase
tenzen-y
force-pushed
the
refactor-snapshot-test
branch
from
188c2bc
to
f004bb9
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This PR is ready for review. /assign @alculquicondor |
Closed
pkg/cache/snapshot_test.go
Outdated
| { | ||
| Name: "demand", | ||
| Min: 100_000, | ||
| wantSnapshot: Snapshot{ |
There was a problem hiding this comment.
maybe you can do
wantSnapshot: func() Snapshot {
cohort := .....
return Snapshot{
}
}
tenzen-y
force-pushed
the
refactor-snapshot-test
branch
from
f004bb9
to
f43f0c3
Compare
pkg/cache/snapshot_test.go
Outdated
| ResourceFlavors: map[string]*kueue.ResourceFlavor{}, | ||
| }, | ||
| }, | ||
| "clusterQueues": { |
There was a problem hiding this comment.
independent clusterQueues
pkg/cache/snapshot_test.go
Outdated
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "with-preemption", | ||
| "workloads": { |
There was a problem hiding this comment.
I would just merge this one with the test case above titled "clusterQueues"
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
refactor-snapshot-test
branch
from
f43f0c3
to
5d67803
Compare
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
@alculquicondor I addressed your comments. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I refactored tests for the snapshot.
Which issue(s) this PR fixes:
Fixes #72,#269
Special notes for your reviewer: