Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two phase admission documentation #1181

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Two phase admission documentation #1181

merged 3 commits into from
Oct 24, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Oct 5, 2023 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Document Admission Checks.

Which issue(s) this PR fixes:

Relates to #993

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 5, 2023
@netlify
Copy link

netlify bot commented Oct 5, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 80f0de2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6537d22a4b3a4600081de730
😎 Deploy Preview https://deploy-preview-1181--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2023
@trasc trasc force-pushed the doc-two-step-admission branch 2 times, most recently from 9c4deab to ee5d271 Compare October 6, 2023 11:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@tenzen-y
Copy link
Member

@trasc Is this still WIP?

@tenzen-y tenzen-y mentioned this pull request Oct 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@trasc trasc changed the title [WIP] Two step admission deocumentation Two step admission documentation Oct 23, 2023
@trasc trasc changed the title Two step admission documentation Two phase admission documentation Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 23, 2023
@trasc trasc marked this pull request as ready for review October 23, 2023 07:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@trasc
Copy link
Contributor Author

trasc commented Oct 23, 2023

@trasc Is this still WIP?

It's ok for review now.

@alculquicondor
Copy link
Contributor

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 23, 2023
alculquicondor
alculquicondor reviewed Oct 23, 2023
View reviewed changes
site/content/en/docs/concepts/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/content/en/docs/concepts/admission_check.md Outdated Show resolved Hide resolved
site/static/examples/sample-admission-check.yaml Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51f728dbc0d24f2a9ae95ae28d747570a170bb21

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4df94cc into kubernetes-sigs:main Oct 24, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 24, 2023
@trasc trasc deleted the doc-two-step-admission branch October 25, 2023 10:14
PBundyra pushed a commit to PBundyra/kueue that referenced this pull request Oct 26, 2023
@trasc @PBundyra
Two phase admission documentation (kubernetes-sigs#1181)
a2d0ca2 
* Two phase admission documentation

* Review Remarks

* Review Remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@kerthcet kerthcet Awaiting requested review from kerthcet

@ahg-g ahg-g Awaiting requested review from ahg-g

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@trasc @k8s-ci-robot @tenzen-y @alculquicondor