Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a plugin mechanism for arbitrary checks during workload admission. #993

Closed
3 tasks
Tracked by #974
mwielgus opened this issue Jul 17, 2023 · 9 comments · Fixed by #994
Closed
3 tasks
Tracked by #974

Introduce a plugin mechanism for arbitrary checks during workload admission. #993

mwielgus opened this issue Jul 17, 2023 · 9 comments · Fixed by #994
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mwielgus
Copy link
Contributor

What would you like to be added:

A mechanism to admit workloads based on both ClusterQueue quota and checks made by an external controller.

Why is this needed:

The current admission process only checks queue resources and doesn't allow to use some cloud provider API or prometheus database query.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor
Copy link
Contributor

/reopen
Implementation is still ongoing

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen
Implementation is still ongoing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trasc
Copy link
Contributor

trasc commented Sep 13, 2023

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@alculquicondor
Copy link
Contributor

/close

This was implemented in 0.5

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

/close

This was implemented in 0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member

@alculquicondor IIRC, we're still working on #1178. Or, we should open a separate issue?

@alculquicondor
Copy link
Contributor

Good point, opened #1677.

PBundyra added a commit to PBundyra/kueue that referenced this issue Oct 17, 2024
PBundyra added a commit to PBundyra/kueue that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants