Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ResourceFlavor to Flavor #123

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Rename ResourceFlavor to Flavor #123

merged 1 commit into from
Mar 17, 2022

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Mar 17, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is in preparation to introduce the ResourceFlavor CRD type.

Which issue(s) this PR fixes:

Part of ##59

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/assign @denkensk

@ahg-g ahg-g mentioned this pull request Mar 17, 2022
Merged
@denkensk
Copy link
Member

/retest

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/retest

prow is broken, check the referenced issue above

@denkensk
Copy link
Member

/retest

1 similar comment
@denkensk
Copy link
Member

/retest

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/retest-required

@denkensk
Copy link
Member

/lgtm

Thanks @ahg-g

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@ArangoGutierrez
Copy link
Contributor

/retest-required

ArangoGutierrez
ArangoGutierrez reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ArangoGutierrez
Copy link
Contributor

/retest-required

@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 17, 2022 •
edited
Loading

@ahg-g: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main aaa6689 link true /test pull-kueue-test-unit-main
pull-kueue-test-integration-main aaa6689 link true /test pull-kueue-test-integration-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

#124 Fixes this errors moving forward

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/retest-required

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/retest

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
alculquicondor
alculquicondor reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alculquicondor
Copy link
Contributor

straightforward

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit c50f61c into kubernetes-sigs:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez ArangoGutierrez left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

@denkensk denkensk

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahg-g @k8s-ci-robot @denkensk @ArangoGutierrez @alculquicondor