Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kueue verify with 1.17 #25657

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Kueue verify with 1.17 #25657

merged 1 commit into from
Mar 16, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Copy link
Contributor Author

golangci/golangci-lint#2438

@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 16, 2022
Merged
@alculquicondor
Copy link
Member

/lgtm
/approve

@ArangoGutierrez
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/lgtm /approve

looks like is back online , but lgtm is not set

@alculquicondor
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArangoGutierrez
Copy link
Contributor Author

/test pull-test-infra-verify-lint

@ArangoGutierrez
Copy link
Contributor Author

/test pull-test-infra-unit-test

@ArangoGutierrez
Copy link
Contributor Author

/test pull-test-infra-verify-lint

@ArangoGutierrez
Copy link
Contributor Author

/retest-required

@ArangoGutierrez
Copy link
Contributor Author

/test pull-test-infra-verify-lint

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-verify-lint a26205e link true /test pull-test-infra-verify-lint
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

yamllint was not happy with the comment

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@ArangoGutierrez
Kueue verify with 1.17
79ffaba 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

Ready for review

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit dae5b5a into kubernetes:master Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 16, 2022
@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-presubmits.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml

In response to this:

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Member

ahg-g commented Mar 17, 2022

what about the other two? pull-kueue-test-unit-main and pull-kueue-test-integration-main; shouldn't we revert that too? I think this is broke presubmit; I am getting https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/123/pull-kueue-test-integration-main/1504281421739462656 on kubernetes-sigs/kueue#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@ArangoGutierrez @alculquicondor @k8s-ci-robot @ahg-g