Retry for ProvisioningRequests KEP #1355
Conversation
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/S
mimowo
force-pushed
the
retry-provisioning-request-kep
branch
from
e8e7aa4 to
cde3c0e
Compare
| // between consecutive attempts are determined by expotential growth up to 30min. | ||
| // +optional | ||
| // +kubebuilder:default=60 | ||
| DefaultBackoffSeconds *int32 `json:"minBackoffSeconds,omitempty"` |
There was a problem hiding this comment.
Default or Min? TBH, minBackoff fits better to exponential backoff.
There was a problem hiding this comment.
Yeah, I was hesitant, minBackoffSeconds sgtm
There was a problem hiding this comment.
Removed the API configuration, just leaving a note about the retries.
mimowo
force-pushed
the
retry-provisioning-request-kep
branch
from
b5383a8 to
1afa809
Compare
k8s-ci-robot
added
size/XS
mimowo
force-pushed
the
retry-provisioning-request-kep
branch
from
1afa809 to
2db7353
Compare
|
@alculquicondor should we move forward with the KEP note, or close it? |
|
I think there is value in making it configurable in future versions, but I'm ok deferring this for later, based on user feedback. |
Sure, for now the PR is just a note about the retry itself. Does not describe the API for configuration. Wondering if the note itself is worth it. |
| * Retry ProvisioningRequests with respect to the `RetryConfig` configuration in | ||
| the `ProvisioningRequestConfig`. For each attempt a new provisioning request is | ||
| created with the suffix indicating the attempt number. The corresponding admission | ||
| check will remain in the `Pending` state until the retries end. |
There was a problem hiding this comment.
Add the note about the number of retries
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 29329b74b0c6d9ffc8910ac8350d96081ba8d329
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Retry for ProvisioningRequests KEP * review comments * Added a note about defaults for retry mechanism
* Retry for ProvisioningRequests KEP * review comments * Added a note about defaults for retry mechanism
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #1353
Special notes for your reviewer:
Does this PR introduce a user-facing change?