Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #2811 to 0.8 #2829

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Cherry-pick #2811 to 0.8 #2829

merged 6 commits into from
Aug 13, 2024

Conversation

gabesaba
Copy link
Contributor

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Cherry-pick #2811 to 0.8

To accomplish this, we cherry-pick several other PRs which this one is based on. This allows us to do a cherry-pick without any manual merge resolution.

Special notes for your reviewer:

Please verify in the following manner:

git checkout 0903547ef7163e5c12ab8f4a426761e8509c0ff2
git cherry-pick f7062d7e5a2aca0f070e9dcb22e2ad3a6243528a
git cherry-pick b348ce4c0e8228a728ba36b03ea5421386e182c0
git cherry-pick 3682278bb668d85f62cdefa955ab7e02991f9951
git cherry-pick 7c9ad4c08a5894e654340e03ad338034bbc19279
git cherry-pick 5c4cd088b12d8ebe640fcff58aef1519e3359d4a
git cherry-pick 615f13d8ed803be066741cca0b9988a6a1b52429
git diff HEAD 8f78e36d6f3c0e7d2a8a0cc705ee3f0b137e79ae

Does this PR introduce a user-facing change?

Update Flavor selection logic to prefer Flavors which allow reclamation of lent nominal quota, over Flavors which require preempting workloads within the ClusterQueue. This matches the behavior in the single Flavor case.

gabesaba and others added 6 commits August 13, 2024 12:27
@gabesaba
Cleanup to use FlavorResourceQuantities.Add in cache (kubernetes-sigs…
b5a755e 
…#2696)
@highpon @gabesaba
fix: Refactor FitInCohort tests (kubernetes-sigs#2655)
46646ef 
* fix: Refactor FitInCohorot tests

* fix: delete no-op function

* fix: use new method to add usage

* fix: to enforce resource group constraint for flavors and resources

* fix: consolidated into a single resource group

* fix: delete flavorNames

* fix: adjusted test cases to align with existing expected conditions

* fix: change FlavorResourceQuantitiesFlat value
@gabesaba
Finish flattening of FlavorResourceQuantities (kubernetes-sigs#2721)
d01fe01 
* Finish Flattenning FlavorResourceQuantities

* Rename FlavorResourceQuantitiesFlat to FlavorResourceQuantities
@gabesaba
Cleanup preemption.go (kubernetes-sigs#2800)
9a2a414
@gabesaba
[Partial Admission] Check Mode before attempting Preemption (kubernet…
f62571d 
…es-sigs#2809)
@gabesaba
Prefer Reclamation to Priority Based Preemption (kubernetes-sigs#2811)
8f78e36
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 8f78e36
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66bb58cf666208000866711d
😎 Deploy Preview https://deploy-preview-2829--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gabesaba
Copy link
Contributor Author

/assign @mimowo @PBundyra

@mimowo
Copy link
Contributor

mimowo commented Aug 13, 2024

All the commits are on the list are categorized as cleanup or bug. There is one bug: #2809, but it does not contain any API changes, so I think we can cherry-pick it too.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4391c4f13fccc8285ba6c78dee6c151986162a08

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 28c7d8b into kubernetes-sigs:release-0.8 Aug 13, 2024
16 checks passed
@gabesaba gabesaba deleted the cherry_2811 branch August 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

@PBundyra PBundyra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@gabesaba @mimowo @k8s-ci-robot @PBundyra @highpon