Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote VisibilityOnDemand to Beta. #3008

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Promote VisibilityOnDemand to Beta. #3008

merged 1 commit into from
Sep 23, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Sep 6, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote VisibilityOnDemand to Beta and enabled by default.

Which issue(s) this PR fixes:

Fixes #2973

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted VisibilityOnDemand to Beta and enabled by default.

ACTION REQUIRED: The v1alpha1 Visibility API is deprecated and will be removed in the next release. Please use v1beta1 instead.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 13ec874
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66efbf5d1de3970008a3d94d
😎 Deploy Preview https://deploy-preview-3008--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi marked this pull request as draft September 6, 2024 14:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@alculquicondor
Copy link
Contributor

/assign @PBundyra

@mbobrovskyi
Copy link
Contributor Author

/retest

@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 4648f54 to 05e289c Compare September 6, 2024 14:38
@mbobrovskyi mbobrovskyi marked this pull request as ready for review September 6, 2024 14:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo September 6, 2024 14:38
@mimowo
Copy link
Contributor

mimowo commented Sep 6, 2024 •
edited
Loading

/hold
Let's investigate the discussion points first: #2973 (comment) and record the findings in the KEP update first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 05e289c to 0bac804 Compare September 6, 2024 16:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 0bac804 to cb687d7 Compare September 10, 2024 13:44
@alculquicondor
Copy link
Contributor

I think we can keep the v1alpha1 API for one release, and put an ACTION REQUIRED in the release notes.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from c8cd128 to 1d680bc Compare September 17, 2024 04:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
This was referenced Sep 18, 2024
Closed
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 1d680bc to c8d8be8 Compare September 19, 2024 07:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from c8d8be8 to 43e211a Compare September 19, 2024 12:32
@mbobrovskyi
Copy link
Contributor Author

@mimowo Could you please take another look?

@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 43e211a to 6ec4a11 Compare September 19, 2024 13:31
@mimowo
Copy link
Contributor

mimowo commented Sep 20, 2024

/assign @PBundyra
for the first pass

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/graduate-visibility-on-demand-to-beta branch from 6ec4a11 to 13ec874 Compare September 22, 2024 06:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2024
@PBundyra
Copy link
Contributor

This looks great, thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c1473dd4f4778011969e1fdf063919f56692616

mimowo
mimowo reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks for everyone involved!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Sep 23, 2024 •
edited
Loading

/unhold

Due to KEP updated on #3032 and #3086 and P&F configs added on #3043.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit c565849 into kubernetes-sigs:main Sep 23, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 23, 2024
@mbobrovskyi mbobrovskyi deleted the feature/graduate-visibility-on-demand-to-beta branch September 23, 2024 13:07
@mbobrovskyi mbobrovskyi mentioned this pull request Nov 9, 2024
Merged
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Promote VisibilityOnDemand feature gate and Visibility API to Beta. (k…
f7b2844 
…ubernetes-sigs#3008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@PBundyra PBundyra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Promote VisibilityOnDemand to Beta
6 participants
@mbobrovskyi @alculquicondor @mimowo @PBundyra @k8s-ci-robot @tenzen-y