Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1alpha1 visibility API #3499

Merged

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Nov 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove the v1alpha1 Visibility API.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

As we discussed here #3008 (comment) we should remove v1alpha1 visibility API on 0.10 version.

Does this PR introduce a user-facing change?

Removed the v1alpha1 Visibility API.

ACTION REQUIRED: The v1alpha1 Visibility API is deprecated. Please use v1beta1 instead.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 9, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2024
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 338788b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6731be53f227910008272846

@trasc
Copy link
Contributor

trasc commented Nov 11, 2024

I think config/components/visibility/apiservice_v1alpha1.yaml should be removed also.
Check the documentation, there may be other references to v1alpha1 there.

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Nov 11, 2024

I think config/components/visibility/apiservice_v1alpha1.yaml should be removed also. Check the documentation, there may be other references to v1alpha1 there.

Thank you so much! I missed API changes.

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo @PBundyra

@mimowo
Copy link
Contributor

mimowo commented Nov 12, 2024

I will leave the first pass to @PBundyra

@PBundyra
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b57dce5b6df4a4e43c8a163b4b135c399de8500b

@mimowo
Copy link
Contributor

mimowo commented Nov 12, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 074a585 into kubernetes-sigs:main Nov 12, 2024
15 of 16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 12, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/remove-visibility-v1alpha1 branch November 12, 2024 10:13
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
* Remove visibility API v1alpha1.

* Remove v1alpha1.visibility.kueue.x-k8s.io APIService.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants