[test][integration] Relax CheckLatestEvent to CheckEventRecordedFor.
#3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
Is it fix for #3144? |
It was not done for it specifically but it's fixing it. |
Awesome. Thanks! |
|
/test pull-kueue-test-e2e-main-1-29 |
|
#3147 created for the e2e flake |
|
@mbobrovskyi would be great if you could provide the first review |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4416005ca2625921d28da81ef68d288fe4ff3ef9
|
mimowo
reviewed
Sep 27, 2024
mbobrovskyi
reviewed
Sep 30, 2024
trasc
force-pushed
the
integration-dont-check-only-last-event
branch
from
4cc9b1a
to
3906c35
Compare
k8s-ci-robot
removed
the
lgtm
trasc
force-pushed
the
integration-dont-check-only-last-event
branch
from
3906c35
to
1fbe011
Compare
trasc
changed the title
CheckLatestEvent to CheckEventRecordedAfterCheckLatestEvent to CheckEventRecordedFor.
mimowo
reviewed
Sep 30, 2024
Instead of expecting that an event is recorded last, check that the event was recorded for a specific object.
|
/test pull-kueue-test-integration-main Due to #3149. |
trasc
force-pushed
the
integration-dont-check-only-last-event
branch
from
e71dc94
to
42454ba
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2e31472a2e7e9320177a2fd9dabac0da9cb23300
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
…r`. (kubernetes-sigs#3145) * [test][integration] Relax `CheckLatestEvent` to `CheckEventRecordedFor`. Instead of expecting that an event is recorded last, check that the event was recorded for a specific object. * [util][testing] Remove `CheckLatestEvent` as is no longer used. * Review Remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
[test][integration] Relax
CheckLatestEventtoCheckEventRecordedFor.Instead of expecting that an event is recorded last, check that the event was recorded for a specific object.
Which issue(s) this PR fixes:
Fixes #3144
Special notes for your reviewer:
Does this PR introduce a user-facing change?