Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all imports using gci linter. #3159

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reformat all imports using gci linter.

Which issue(s) this PR fixes:

Fixes #2198

Special notes for your reviewer:

We already removed the kube-builder scaffolding in #2946, so we can now enable the GCI linter.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2024
Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6ed0731
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66f91383efb9bf00081c1ade

@mbobrovskyi mbobrovskyi force-pushed the cleanup/reformat-all-imports-using-gci-linter branch from 02e136c to 200db48 Compare September 29, 2024 08:39
@mbobrovskyi mbobrovskyi force-pushed the cleanup/reformat-all-imports-using-gci-linter branch from 200db48 to 6ed0731 Compare September 29, 2024 08:44
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Sep 29, 2024

@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

Again

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@mimowo
Copy link
Contributor

mimowo commented Sep 30, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c0b688dc7c7d86808d9abc1f7d5adea7ee19b7e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5a30ebb into kubernetes-sigs:main Sep 30, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 30, 2024
@alculquicondor
Copy link
Contributor

I remember we couldn't enable it before because it would remove kubebuilder scaffolding comments #2184

Good thing we got rid of them :)

@mbobrovskyi mbobrovskyi deleted the cleanup/reformat-all-imports-using-gci-linter branch September 30, 2024 13:18
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat all imports using gci linter
4 participants