-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat all imports using gci linter. #3159
Reformat all imports using gci linter. #3159
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
02e136c
to
200db48
Compare
200db48
to
6ed0731
Compare
/test pull-kueue-test-integration-main https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/3159/pull-kueue-test-integration-main/1840311859530436608 should be solved by #3145. |
/test pull-kueue-test-integration-main Again |
/cc @mimowo |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9c0b688dc7c7d86808d9abc1f7d5adea7ee19b7e
|
I remember we couldn't enable it before because it would remove kubebuilder scaffolding comments #2184 Good thing we got rid of them :) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reformat all imports using gci linter.
Which issue(s) this PR fixes:
Fixes #2198
Special notes for your reviewer:
We already removed the kube-builder scaffolding in #2946, so we can now enable the GCI linter.
Does this PR introduce a user-facing change?