KEP-3122: Expose Flavors in LocalQueue Status. #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/L
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
2 times, most recently
from
de22c76
to
49f8a71
Compare
|
/cc @mimowo |
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
2 times, most recently
from
edbee25
to
9a21200
Compare
mimowo
reviewed
Oct 2, 2024
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
2 times, most recently
from
6ca0be3
to
de539a4
Compare
mimowo
reviewed
Oct 8, 2024
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
from
de539a4
to
21a8718
Compare
|
/lgtm I think this is a good starting point. The API model is flexible so we can extend it in the future by the list of resources, or quotas. For now, I'm not fully sure if publishing the resource quotas would not be leaking too much admin information to the end users for some environments, so maybe we can defer it for later when we have some more concrete use-cases. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0b8d7fb3a18f033e58fb8e203efe76df85f5652a
|
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
from
296b526
to
a2579aa
Compare
tenzen-y
reviewed
Oct 10, 2024
tenzen-y
reviewed
Oct 14, 2024
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
from
059078f
to
b296cc0
Compare
tenzen-y
reviewed
Oct 14, 2024
mbobrovskyi
force-pushed
the
docs/kep-3122
branch
from
b296cc0
to
c542b2f
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f7869bdb39ea45270b290dd684ae4c3b3ee3ddda
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
* KEP-3122: Expose Flavors in LocalQueue Status. * Add resources field on AvailableFlavor struct. * Add Risks and Mitigations section. * Add additional fields to AvailableFlavor struct. * Add future work section. * Add additional test case. * Add stopPolicies non-goal. * Rename availableFlavors to flavors. * Add feature gate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
KEP for Expose Flavors in LocalQueue Status.
Which issue(s) this PR fixes:
Part of #3122
Special notes for your reviewer:
Does this PR introduce a user-facing change?