Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.2 update #357

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Release 0.2 update #357

merged 2 commits into from
Aug 25, 2022

Conversation

alculquicondor
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Update version in install instructions and manifests.

Which issue(s) this PR fixes:

Part of #352

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2022
@alculquicondor
Copy link
Contributor Author

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2022
@alculquicondor
Update install instructions to 0.2.0
586948d 
Change-Id: Ia4e7b2158ceccd9611a88c554ef47e772ba60c39
@alculquicondor
Match release-0.2 tags in manifests
a8913bb 
Change-Id: I2bd2c72887b07d66dc7ae166ef9430d6998fc3c3
@alculquicondor alculquicondor mentioned this pull request Aug 25, 2022
Closed
20 tasks
@alculquicondor
Copy link
Contributor Author

/assign @ahg-g

ArangoGutierrez
ArangoGutierrez reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 nit questions

Makefile
@@ -164,7 +164,7 @@ ifndef ignore-not-found
ignore-not-found = false
endif

clean-manifests = (cd config/components/manager && $(KUSTOMIZE) edit set image controller=gcr.io/k8s-staging-kueue/kueue:main)
clean-manifests = (cd config/components/manager && $(KUSTOMIZE) edit set image controller=gcr.io/k8s-staging-kueue/kueue:release-0.2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why moving from main here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops wrong target branch. This is for the release-0.2 branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaahhhh ;P

config/components/manager/kustomization.yaml
@@ -14,4 +14,4 @@ kind: Kustomization
images:
- name: controller
newName: gcr.io/k8s-staging-kueue/kueue
newTag: main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same answer 😅

ahg-g
ahg-g reviewed Aug 25, 2022
View reviewed changes
Makefile
@@ -164,7 +164,7 @@ ifndef ignore-not-found
ignore-not-found = false
endif

clean-manifests = (cd config/components/manager && $(KUSTOMIZE) edit set image controller=gcr.io/k8s-staging-kueue/kueue:main)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this set to main and not 0.1.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto the other instances below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the release-0.2 branch (I fixed the target).

@alculquicondor alculquicondor changed the base branch from main to release-0.2 August 25, 2022 19:58
ArangoGutierrez
ArangoGutierrez approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ddadb5b into kubernetes-sigs:release-0.2 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Assignees

@ArangoGutierrez ArangoGutierrez

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alculquicondor @k8s-ci-robot @ArangoGutierrez @ahg-g