Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.2 update #357

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Release 0.2 update #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
586948d
Update install instructions to 0.2.0
alculquicondor Aug 25, 2022
a8913bb
Match release-0.2 tags in manifests
alculquicondor Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ ifndef ignore-not-found
ignore-not-found = false
endif

clean-manifests = (cd config/components/manager && $(KUSTOMIZE) edit set image controller=gcr.io/k8s-staging-kueue/kueue:main)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this set to main and not 0.1.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto the other instances below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the release-0.2 branch (I fixed the target).

clean-manifests = (cd config/components/manager && $(KUSTOMIZE) edit set image controller=gcr.io/k8s-staging-kueue/kueue:release-0.2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why moving from main here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops wrong target branch. This is for the release-0.2 branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaahhhh ;P


.PHONY: install
install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config.
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ admission control can be delegated to controllers such as [gatekeeper](https://g
To install the latest release of Kueue in your cluster, run the following command:

```shell
kubectl apply -f https://github.com/kubernetes-sigs/kueue/releases/download/v0.1.1/manifests.yaml
kubectl apply -f https://github.com/kubernetes-sigs/kueue/releases/download/v0.2.0/manifests.yaml
```

The controller runs in the `kueue-system` namespace.
Expand Down
2 changes: 1 addition & 1 deletion config/components/manager/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ kind: Kustomization
images:
- name: controller
newName: gcr.io/k8s-staging-kueue/kueue
newTag: main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same answer 😅

newTag: release-0.2
10 changes: 5 additions & 5 deletions docs/setup/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The webhook server in kueue uses an internal cert management for provisioning ce
To install a released version of Kueue in your cluster, run the following command:

```shell
VERSION=v0.1.1
VERSION=v0.2.0
kubectl apply -f https://github.com/kubernetes-sigs/kueue/releases/download/$VERSION/manifests.yaml
```

Expand All @@ -44,7 +44,7 @@ kubectl apply -f https://github.com/kubernetes-sigs/kueue/releases/download/$VER
To uninstall a released version of Kueue from your cluster, run the following command:

```shell
VERSION=v0.1.1
VERSION=v0.2.0
kubectl delete -f https://github.com/kubernetes-sigs/kueue/releases/download/$VERSION/manifests.yaml
```

Expand All @@ -60,14 +60,14 @@ To install a custom-configured released version of Kueue in your cluster, execut
1. Download the release's `manifests.yaml` file:

```shell
VERSION=v0.1.1
VERSION=v0.2.0
wget https://github.com/kubernetes-sigs/kueue/releases/download/$VERSION/manifests.yaml
```
2. With an editor of your preference, open `manifests.yaml`.
3. In the `kueue-manager-config` ConfigMap manifest, edit the
`controller_manager_config.yaml` data entry. The entry represents
the default Kueue Configuration
struct ([v1alpha1@v0.1.1](https://pkg.go.dev/sigs.k8s.io/kueue@v0.1.1/apis/config/v1alpha1#Configuration)).
struct ([v1alpha1@v0.2.0](https://pkg.go.dev/sigs.k8s.io/kueue@v0.2.0/apis/config/v1alpha1#Configuration)).
The contents of the ConfigMap are similar to the following:

```yaml
Expand Down Expand Up @@ -101,7 +101,7 @@ To install the latest development version of Kueue in your cluster, run the
following command:

```shell
kubectl apply -k github.com/kubernetes-sigs/kueue/config/default?ref=main
kubectl apply -k github.com/kubernetes-sigs/kueue/config/default?ref=release-0.2
```

The controller runs in the `kueue-system` namespace.
Expand Down