-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the hashing too restrictive for custom transformation of custom resources? #1167
Comments
For other types, maybe just hash the bytes for the unstructured object. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I wrote a simple custom transformation plugin to apply sealed-secrets to the 'Secrets' resource only of an input yaml. This results in a new custom resource,
SealedSecrets
that, unfortunately,kustomize
rejects because it can't hash it:https://github.com/kubernetes-sigs/kustomize/blob/master/k8sdeps/kunstruct/hasher.go#L25
For details of the experiment, see: bitnami-labs/sealed-secrets#167 (comment)
It seems to me that with custom generator and transformer plugins,
kustomize
ought to be able to pass custom resources that it does not recognize as-is instead of failing completely.The text was updated successfully, but these errors were encountered: