-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hash suffixing of arbitrary types #2737
Allow hash suffixing of arbitrary types #2737
Conversation
Welcome @tinselspoon! |
Hi @tinselspoon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sure, sounds good. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole, tinselspoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! |
When using a custom generator plugin, the
kustomize.config.k8s.io/needs-hash
hash suffix generator only works forConfigMap
andSecret
resources, and fails the build process if used on a different type of resource. I had hit the exact same issue as described in #1167, where I wanted to use a generator plugin to create a customSealedSecret
resource with a hash suffix, as it should behave the same as a built-inSecret
.This change applies the suggested approach commented in #1167 (before it was auto-closed for inactivity) which is to hash the entire object for unknown types.
I appreciate the original issue is a little old and this approach may no longer be wanted, but I wanted to put this for your consideration just in case.