-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize edit add resource remoteurl shouldn't require validation #3276
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
/assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale @ChaturvediSulabh did you get anywhere with this? |
@james-callahan, Have received feedback just last week, working on implementing changes. Apologies for the delay, however, looking at the comments, this might take some more time. |
I'll try to finish the work by this weekend. Apologies for the delay. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@james-callahan: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@natasha41575: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Any progress on this? |
/assign |
Just approved #5333, so closing this issue now. The |
Running
kustomize edit add resource git@github.com/myorg/myrepo/kustomize/base?ref=abcdef
shouldn't require network connectivity or permission to the repo.We generate some of our kustomizations in a locked down environment that doesn't have a valid key to the relevant repository.
Additionally, (and especially for non-locked references e.g.
?ref=master
), what may be valid today may not be valid later, and vice versa: I may be creating the kustomization before pushing.One possible solution would be adding a flag such as
--validate=false
that just assumes the resource is valid and skips the network accessAdditional context
kustomize edit add
was added in Support remote resources for kustomize edit add #2768The text was updated successfully, but these errors were encountered: