-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tasks Documentation #5346
Add Tasks Documentation #5346
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ncapps. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ncapps The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving just a few minor suggestions. Good work though.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this sentence, the doc is referring to the users as if they are third party.
So it sort of makes as feel like this doc is for the contributors to read, not the actual users of kustomize. Same goes for all the other first sentences of Motivation.
Users may want to define a common set of labels or annotations for all the Resources in a project. | |
It's possible to define a common set of labels or annotations for all the Resources in a project. |
Users may want to define a common set of labels or annotations for all the Resources in a project. | |
You can define a common set of labels or annotations for all the Resources in a project. |
## Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the section name Motivation is necessary.
## Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Motivation header was copied from the original site here. All other Task pages include a Motivation section as an introduction to the concept.
Personally, I think it makes sense to keep this header but I can remove if you feel strongly that it is not helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's OK to keep the header if you think it's useful.
I think the tests aren't triggering because of #5332, I'm going to revert that one today. |
@ncapps Thanks so much for working on this section! You did exactly as the sheet instructed, which was to leave only the conceptual information in the "core_tasks" section. Unfortunately, I didn't write this sheet, and didn't catch these comments. Sorry in advance. I found that the structure of the Tasks section in the Kubernetes documentation belies the excel sheet comments in that their Tasks section only documents concrete examples or as they call it, "a short sequence of steps". I wanted to discuss with you what our Tasks section should hold. If we follow the Kubernetes example, we can discuss on this PR where to move the content or work to merge this PR with the assumption that we'll move it in the future. |
Hi @annasong20, Thanks for taking a look at my PR. Please let me know what you envision for the Kustomize Tasks section and I will update this PR accordingly. |
Hi @ncapps, sorry for the delayed response. Also feel free to DM me on Slack if that's faster. I don't have a great vision of all the sub-sections, but my reasoning was that in the absence of strong opinions, our site might be easier to understand if it follows the same format as Kubernetes. Their Tasks section seems to feature concrete steps for accomplishing simple workflows, aka Tasks. Taking
seem like they belong under I also think we might benefit from working on 1 or a few fields at a time. We can finalize our approach at a smaller scope and then you can apply it to all other fields. This way, we don't waste your time applying dissented changes between reviews. Disclaimer that my take is not authoritative. Feel free to push back where you disagree! Treating this more like a collaboration. |
This change adds content to the Core Tasks section of the new documentation site.
Resolves: #5286