-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dependency pinning and update automation #5451
Feature/dependency pinning and update automation #5451
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @antoooks. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
09546a7
to
b94888f
Compare
/ok-to-test |
/assign koba1t |
@antoooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I reviewed this PR. Please check my comments.
This code looks almost good! |
It's weird, I ran lint locally and it came out fine. But if it ran on CI it throws many check errors @koba1t do you know how I can reproduce same linting rule as CI? |
hmm... |
* add managerfactory handling for local flag * add shortName handling for local flag * add dot git file handling for local flag * add tests
5335512
to
276cc0c
Compare
/label tide/merge-method-squash |
Hi @antoooks
|
@koba1t Nice catch, I assumed we use separate release branch so I didn't work on unpin, but I think I should to support backward compatibility. Will fix it now, thanks Yugo-san |
/uncc |
Thanks, @antoooks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoooks, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gorepomod
to work outside $GOSRC, by adding--local
gorepomod list
andgorepomod pin
patch
unpin
Note:
implementation done based on assumption that the release process will producerelease-{module}-vX.Y.Z
release branch naming. And this branch is created manually when releasing which will become trigger to the CI stepsAddresses #5404