Merge pull request #1928 from elezar/cherry-pick-testdata-changes

Cherry pick testdata changes

source/pci/pci_test.go

@@ -18,7 +18,6 @@ package pci
 
 import (
 	"path/filepath"
-	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -27,13 +26,6 @@ import (
 	"sigs.k8s.io/node-feature-discovery/source"
 )
 
-var packagePath string
-
-func init() {
-	_, thisFile, _, _ := runtime.Caller(0)
-	packagePath = filepath.Dir(thisFile)
-}
-
 func TestSingletonPciSource(t *testing.T) {
 	assert.Equal(t, src.Name(), Name)
 
@@ -232,7 +224,8 @@ func TestPciSource(t *testing.T) {
 	// Run test cases
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			hostpath.SysfsDir = hostpath.HostDir(filepath.Join(packagePath, "testdata", tc.rootfs, "sys"))
+			mockSysfsPath := filepath.Join("..", "..", "testdata", "source", "pci", tc.rootfs, "sys")
+			hostpath.SysfsDir = hostpath.HostDir(mockSysfsPath)
 
 			config := tc.config
 			if config == nil {

testdata/README.md

@@ -0,0 +1,3 @@
+Some of the test data in this folder contains colon characters which causes "go get" commands to fail with "invalid char ':'".
+The empty go.mod file is a workaround to prevent this error. This effectively makes this folder its own go module, so it will be
+ignored when "go get" is executed.

testdata/go.mod

@@ -0,0 +1,3 @@
+// This empty go.mod file ensures that the testdata folder is not included
+// in the top-level module. This prevents issues such as unsupported characters
+// in path names.