Cherry pick testdata changes #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go mod automatically ignores the /testdata directory. This change ensures that the rootfs for source/pci tests are not included in the module definition. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This ensures that the testdata folder is not included in the top-level module and prevents issues such as unsupported characters in path names. Signed-off-by: Evan Lezar <elezar@nvidia.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fbb132296e73c5edc0d2fe7b7eb66073a4f9696e
|
|
/assign @marquiz |
|
/test pull-node-feature-discovery-build-image-cross-generic |
1 similar comment
|
/test pull-node-feature-discovery-build-image-cross-generic |
|
If we agree on this PR we will need to cut a |
marquiz
approved these changes
Oct 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elezar, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the changes from:
And will allow the next release of v0.16.x to be treated as a go module.