Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move testdata to root #1921

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Move testdata to root #1921

merged 1 commit into from
Oct 22, 2024

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Oct 21, 2024

Go mod automatically ignores the /testdata directory. This change ensures that the rootfs for source/pci tests are not included in the module definition.

This replaces #1919

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit b6b1335
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6716970190b2dc0008f4818b
😎 Deploy Preview https://deploy-preview-1921--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elezar elezar mentioned this pull request Oct 21, 2024
Closed
@marquiz
Copy link
Contributor

marquiz commented Oct 21, 2024

Makes sense 👍 We just need to make the tests pass

@ArangoGutierrez ArangoGutierrez self-assigned this Oct 21, 2024
@ArangoGutierrez
Copy link
Contributor

PR elezar#1 fixes tests

@elezar
Move testdata to root
b6b1335 
Go mod automatically ignores the /testdata directory.
This change ensures that the rootfs for source/pci tests are not
included in the module definition.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the move-source-pci-testdata branch from 4a82a64 to b6b1335 Compare October 21, 2024 18:01
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the lgtm to @marquiz

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, elezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@ArangoGutierrez
Copy link
Contributor

/test pull-node-feature-discovery-build-image-cross-generic

@ArangoGutierrez ArangoGutierrez added this to the v0.17 milestone Oct 21, 2024
@ArangoGutierrez
Copy link
Contributor

/milestone v0.17

@elezar
Copy link
Contributor Author

elezar commented Oct 21, 2024

@ArangoGutierrez @marquiz given that this should address issues in importing the API and client packages could this also be backported to the v0.16.x branch?

@elezar elezar mentioned this pull request Oct 21, 2024
Closed
@marquiz
Copy link
Contributor

marquiz commented Oct 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81765fb6ceeed92eb80c2c04981bc9ba8dded491

@k8s-ci-robot k8s-ci-robot merged commit b9d7fa0 into kubernetes-sigs:master Oct 22, 2024
10 checks passed
@elezar elezar deleted the move-source-pci-testdata branch October 23, 2024 10:03
@elezar elezar mentioned this pull request Oct 23, 2024
Merged
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 25, 2024
Closed
15 tasks
@marquiz marquiz mentioned this pull request Dec 12, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@marquiz marquiz

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@elezar @marquiz @ArangoGutierrez @k8s-ci-robot