Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to v1.23 #1858

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Bump Go to v1.23 #1858

merged 1 commit into from
Sep 5, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 30, 2024

NOTE: api/nfd/go.mod is not bumped. There should be no need to force the importers of the API to v1.23 (yet).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit bf99c47
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66d7fc5efd4aec0008338b20
😎 Deploy Preview https://deploy-preview-1858--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz marquiz mentioned this pull request Aug 30, 2024
Merged
@marquiz
Copy link
Contributor Author

marquiz commented Aug 30, 2024

We need kubernetes/test-infra#33392

@marquiz
Copy link
Contributor Author

marquiz commented Sep 3, 2024

/retest

@marquiz
Bump Go to v1.23
bf99c47 
NOTE: api/nfd/go.mod is not bumped. There should be no need to force the
importers of the API to v1.23 (yet).
@ArangoGutierrez
Copy link
Contributor

/test all

ArangoGutierrez
ArangoGutierrez approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 24c6216aac16b0ab47a1923d23e50e68d751613a

@k8s-ci-robot k8s-ci-robot merged commit 6202745 into kubernetes-sigs:master Sep 5, 2024
10 checks passed
@marquiz marquiz mentioned this pull request Dec 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @ArangoGutierrez @k8s-ci-robot