Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-sigs/nfd: bump golang to v1.23 #33392

Merged
merged 1 commit into from
Sep 2, 2024
Merged

kubernetes-sigs/nfd: bump golang to v1.23 #33392

merged 1 commit into from
Sep 2, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 30, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Aug 30, 2024

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok August 30, 2024 12:59
@marquiz marquiz mentioned this pull request Aug 30, 2024
Merged
ArangoGutierrez
ArangoGutierrez approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 29bc3ac into kubernetes:master Sep 2, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@marquiz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-feature-discovery-periodics.yaml using file config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-periodics.yaml
  • key node-feature-discovery-presubmits-master.yaml using file config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-master.yaml

In response to this:

Refs: kubernetes-sigs/node-feature-discovery#1858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz marquiz deleted the devel/nfd branch September 3, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kad kad Awaiting requested review from kad

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez