More extensive and expressive custom rules #464

marquiz · 2021-03-04T20:55:35Z

Overview

The main goal of this PR is to greatly expand the capabilities of the custom source, and, to make easier to extend in the future. After this change basically all features from the cpu, kernel, system pci, usb and local source are available for custom rule processing. This is achieved in three steps

Decouple "raw" feature discovery and label generation in the feature sources
Introduce a generalized and more expressive rule processing infrastructure, inspired by the MatchExpressions pattern in K8s nodeSelector (also, convert all existing rules to utilize this)
Implement a generic per domain/feature custom rule for matching all features from sources that support "raw" feature discovery (i.e. cpu, kernel, system pci, usb and local in this PR)

This PR introduces a new format for custom rules where the new capabilities are available under new matchFeatures directive. The old rule format (with matchOn) is still supported to provice backwards compatibility.

Rule syntax

A new format for custom rule specifications is introduced, dropping the 'value' field and introducing new 'labels' field which makes it possible to specify multiple labels per rule. Also, in the new format the 'name' field is just for reference and no matching label is created.

  - name: <rule-name>
    labels:
      <key>: <value>
      ...
    matchFeatures:
      - feature: <domain>.<feature>
        matchExpressions:
          <attribute>:
            op: <operator>
            value:
              - <list-of-values>
      - feature: <domain>.<feature>
        ...

Currently supported ops are In, NotIn, InRegexp, Exists, DoesNotExist, Gt Lt, GtLt, IsTrue, IsFalse.

The list of available <domain>.<feature>'s is:

cpu.cpuid:
<cpuid-flag>: <exists/does-not-exist>
cpu.cstate:
enabled: <bool>
cpu.pstate:
status: <string>
turbo: <bool>
scaling_governor: <string>
cpu.rdt:
<rdt-feature>: <exists/does-not-exist>
cpu.sst:
bf.enabled: <bool>
cpu.topology:
hardware_multithreading: <bool>
kernel.config:
<flag-name>: <string>
kernel.loadedmodule:
<module-name>: <exists/does-not-exist>
kernel.selinux:
enabled: <bool>
kernel.version:
major: <int>
minor: <int>
revision: <int>
full: <string>
system.osrelease:
<key-name>: <string>
VERSION_ID.major: <int>
VERSION_ID.minor: <int>
system.name:
nodename: <string>
pci.device:
<device-instance>:
class: <string>
vendor: <string>
device: <string>
subsystem_vendor: <string>
susbystem_device: <string>
sriov_totalvfs: <int>
usb.device:
<device-instance>:
class: <string>
vendor: <string>
device: <string>
serial: <string>
local.label:
<label-name>: <string>

Examples

The following example below demonstrates the new capabilities:

sources:
  custom:
  - name: "my cpu test rule"
    labels:
      cpu-test-feature: "true"
    matchFeatures:
    - feature: cpu.cpuid
      matchExpressions: ["AVX", "AESNI"]
    - feature: cpu.pstate
      matchExpressions: ["turbo=false"]
    - feature: cpu.rdt
      matchExpressions:
        RDTL3CA: {op: Exists}
    - feature: cpu.power
      matchExpressions:
        sst_bf.enabled: true
    - feature: cpu.topology
      matchExpressions:
        hardwareMultithreading: {op: IsTrue}

  - name: "my kernel test rule"
    labels:
      kernel-test-feature: "true"
    matchFeatures:
    - feature: kernel.loadedmodule
      matchExpressions: ["sbs"]
    - feature: kernel.config
      matchExpressions:
        X86:
        LOG_BUF_SHIFT: {op: Gt, value: ["17"]}
    - feature: kernel.version
      matchExpressions:
        major: {op: Gt, value: ["3"]}
        minor: {op: Gt, value: ["18"]}
    - feature: kernel.selinux
      matchExpressions:
        enabled: true

  - name: "my system test rule"
    labels:
      system-test-feature: "true"
    matchFeatures:
    - feature: system.osrelease
      matchExpressions:
        NAME: {op: InRegexp, value: ["^openSuse.*"]}
        VERSION_ID.major: {op: GtLt, value: ["13", "15"]}
    - feature: system.name
      matchExpressions:
        nodename: {op: InRegexp, value: ["xyz-.*-prod", "rack[0-9]-"]}

  - name: "my local test rule"
    labels:
      local-test-feature: "true"
    matchFeatures:
    - feature: local.label
      matchExpressions:
        example.com/local-feature: {op: Lt, value: ["200"]}

The example above also demonstrates some "shortcuts / shortforms" that are wired in the rule parsing

Example 1:

cpu.cpuid: ["AVX", "AESNI"]

is the same as

cpu.cpuid:
  "AVX": {op: Exists}
  "AESNI": {op: Exists}

Example 2:

kernel.config: ["X86", "INIT_ENV_ARG_LIMIT=32"]

is the same as

kernel.config:
  X86:
  INIT_ENV_ARG_LIMIT: {op: In, value: ["32"]}

is the same as

kernel.config:
  X86: {op: Exists}
  INIT_ENV_ARG_LIMIT: {op: In, value: ["32"]}

Example 3:

cpu.power
  sst_bf.enabled: true

is the same as

cpu.power
  sst_bf.enabled: {op: In, value["true"]}

matchAny

In addition to matchFeatures, the PR also implements a new 'matchAny' directive. MatchAny applies a logical OR over multiple matchFeatures matchers. That is, it allows specifying multiple alternative matchers (at least one of which must match) in a single label rule.

The configuration format for the new matcher is

  matchAny:
    - matchFeatures:
        - feature: <domain>.<feature>
          matchExpressions:
            <attribute>:
              op: <operation>
              value:
                - <list-of-values>
    - matchFeatures:
      ...

A configuration example. In order to require a cpu feature, kernel
module and one of two specific PCI devices (taking use of the shortform
notation):

  - name: multi-device-test
    labels: {multi-device-feature: "true"}
    matchFeatures:
      - feature: kernel.loadedmodule
        matchExpressions: [driver-module]
      - feature: cpu.cpuid
        matchExpressions: [AVX512F]
    matchAny:
      - matchFeatures:
          - feature; pci.device
            matchExpressions:
              vendor: "8086"
              device: "1234"
      - matchFeatures:
          - feature: pci.device
            matchExpressions:
              vendor: "8086"
              device: "abcd"

Notes

Documentation is out of the scope of this PR. Documentation will require major changes and will be addressed in a separate PR, also covering #550 and #553.

k8s-ci-robot · 2021-03-04T20:55:36Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2021-03-04T20:55:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marquiz · 2021-03-05T06:19:08Z

Even if in the proto stage, any feedback on the concept, data model, configuration model etc would be more than welcome 😉

marquiz · 2021-03-08T07:42:38Z

Fixed unit tests and added IsTrue and IsFalse ops

ArangoGutierrez · 2021-04-20T20:05:27Z

/assign

marquiz · 2021-11-11T16:43:55Z

Rebased, one comment (copyright year) addressed

@marquiz The same error from PR #604

Yeah, should be now fixed in #604 (and this one, too)

marquiz · 2021-11-11T16:48:26Z

So still #604 and #639 to go before this one.

marquiz · 2021-11-11T21:21:44Z

#604 was merged so we're one step away from this

Implement generic feature matchers that cover all feature sources (that implement the FeatureSource interface). The implementation relies on the unified data model provided by the FeatureSource interface as well as the generic expression-based rule processing framework that was added to the source/custom/expression package. With this patch any new features added will be automatically available for custom rules, without any additional work. Rule hierarchy follows the source/feature hierarchy by design. This patch introduces a new format for custom rule specifications, dropping the 'value' field and introducing new 'labels' field which makes it possible to specify multiple labels per rule. Also, in the new format the 'name' field is just for reference and no matching label is created. The new generic rules are available in this new rule format under a 'matchFeatures. MatchFeatures implements a logical AND over an array of per-feature matchers - i.e. a match for all of the matchers is required. The goal of the new rule format is to make it better follow K8s API design guidelines and make it extensible for future enhancements (e.g. addition of templating, taints, annotations, extended resources etc). The old rule format (with cpuID, kConfig, loadedKMod, nodename, pciID, usbID rules) is still supported. The rule format (new vs. old) is determined at config parsing time based on the existence of the 'matchOn' field. The new rule format and the configuration format for the new matchFeatures field is - name: <rule-name> labels: <key>: <value> ... matchFeatures: - feature: <domain>.<feature> matchExpressions: <attribute>: op: <operator> value: - <list-of-values> - feature: <domain>.<feature> ... Currently, "cpu", "kernel", "pci", "system", "usb" and "local" sources are covered by the matshers/feature selectors. Thus, the following features are available for matching with this patch: - cpu.cpuid: <cpuid-flag>: <exists/does-not-exist> - cpu.cstate: enabled: <bool> - cpu.pstate: status: <string> turbo: <bool> scaling_governor: <string> - cpu.rdt: <rdt-feature>: <exists/does-not-exist> - cpu.sst: bf.enabled: <bool> - cpu.topology: hardware_multithreading: <bool> - kernel.config: <flag-name>: <string> - kernel.loadedmodule: <module-name>: <exists/does-not-exist> - kernel.selinux: enabled: <bool> - kernel.version: major: <int> minor: <int> revision: <int> full: <string> - system.osrelease: <key-name>: <string> VERSION_ID.major: <int> VERSION_ID.minor: <int> - system.name: nodename: <string> - pci.device: <device-instance>: class: <string> vendor: <string> device: <string> subsystem_vendor: <string> susbystem_device: <string> sriov_totalvfs: <int> - usb.device: <device-instance>: class: <string> vendor: <string> device: <string> serial: <string> - local.label: <label-name>: <string> The configuration also supports some "shortforms" for convenience: matchExpressions: [<attr-1>, <attr-2>=<val-2>] --- matchExpressions: <attr-3>: <attr-4>: <val-4> is equal to: matchExpressions: <attr-1>: {op: Exists} <attr-2>: {op: In, value: [<val-2>]} --- matchExpressions: <attr-3>: {op: Exists} <attr-4>: {op: In, value: [<val-4>]} In other words: - feature: kernel.config matchExpressions: ["X86", "INIT_ENV_ARG_LIMIT=32"] - feature: pci.device matchExpressions: vendor: "8086" is the same as: - feature: kernel.config matchExpressions: X86: {op: Exists} INIT_ENV_ARG_LIMIT: {op: In, values: ["32"]} - feature: pci.device matchExpressions: vendor: {op: In, value: ["8086"] Some configuration examples below. In order to match a CPUID feature the following snippet can be used: - name: cpu-test-1 labels: cpu-custom-feature: "true" matchFeatures: - feature: cpu.cpuid matchExpressions: AESNI: {op: Exists} AVX: {op: Exists} In order to match against a loaded kernel module and OS version: - name: kernel-test-1 labels: kernel-custom-feature: "true" matchFeatures: - feature: kernel.loadedmodule matchExpressions: e1000: {op: Exists} - feature: system.osrelease matchExpressions: NAME: {op: InRegexp, values: ["^openSUSE"]} VERSION_ID.major: {op: Gt, values: ["14"]} In order to require a kernel module and both of two specific PCI devices: - name: multi-device-test labels: multi-device-feature: "true" matchFeatures: - feature: kernel.loadedmodule matchExpressions: driver-module: {op: Exists} - pci.device: vendor: "8086" device: "1234" - pci.device: vendor: "8086" device: "abcd"

Implement a new 'matchAny' directive in the new rule format, building on top of the previously implemented 'matchFeatures' matcher. MatchAny applies a logical OR over multiple matchFeatures directives. That is, it allows specifying multiple alternative matchers (at least one of which must match) in a single label rule. The configuration format for the new matchers is matchAny: - matchFeatures: - feature: <domain>.<feature> matchExpressions: <attribute>: op: <operator> value: - <list-of-values> - matchFeatures: ... A configuration example. In order to require a cpu feature, kernel module and one of two specific PCI devices (taking use of the shortform notation): - name: multi-device-test labels: multi-device-feature: "true" matchFeatures: - feature: kernel.loadedmodule matchExpressions: [driver-module] - feature: cpu.cpuid matchExpressions: [AVX512F] matchAny: - matchFeatures: - feature; pci.device matchExpressions: vendor: "8086" device: "1234" - matchFeatures: - feature: pci.device matchExpressions: vendor: "8086" device: "abcd"

Print out the result of applying an expression. Also, truncate the output to max 10 elements (of items matched against) unless '-v 4' verbosity level is in use.

ArangoGutierrez · 2021-11-12T15:26:56Z

First manual test

Name:               minikube
Roles:              control-plane,master
Labels:             beta.kubernetes.io/arch=amd64
                    beta.kubernetes.io/os=linux
                    feature.node.kubernetes.io/cpu-cpuid.ADX=true
                    feature.node.kubernetes.io/cpu-cpuid.AESNI=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX2=true
                    feature.node.kubernetes.io/cpu-cpuid.FMA3=true
                    feature.node.kubernetes.io/cpu-cpuid.HYPERVISOR=true
                    feature.node.kubernetes.io/cpu-cpuid.IBPB=true
                    feature.node.kubernetes.io/cpu-cpuid.MPX=true
                    feature.node.kubernetes.io/cpu-cpuid.STIBP=true
                    feature.node.kubernetes.io/cpu-cpuid.VMX=true
                    feature.node.kubernetes.io/cpu-hardware_multithreading=false
                    feature.node.kubernetes.io/kernel-config.NO_HZ=true
                    feature.node.kubernetes.io/kernel-config.NO_HZ_IDLE=true
                    feature.node.kubernetes.io/kernel-version.full=4.19.202
                    feature.node.kubernetes.io/kernel-version.major=4
                    feature.node.kubernetes.io/kernel-version.minor=19
                    feature.node.kubernetes.io/kernel-version.revision=202
                    feature.node.kubernetes.io/system-os_release.ID=buildroot
                    feature.node.kubernetes.io/system-os_release.VERSION_ID=2021.02.4
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.major=2021
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.minor=02
                    kubernetes.io/arch=amd64
                    kubernetes.io/hostname=minikube                                                                                                                                                                                           
                    kubernetes.io/os=linux                                                                                                                                                                                                    
                    minikube.k8s.io/commit=76b94fb3c4e8ac5062daf70d60cf03ddcc0a741b                                                                                                                                                           
                    minikube.k8s.io/name=minikube                                                                                                                                                                                             
                    minikube.k8s.io/updated_at=2021_11_11T11_09_13_0700                                                                                                                                                                       
                    minikube.k8s.io/version=v1.24.0                                                                                                                                                                                           
                    node-role.kubernetes.io/control-plane=                                                                                                                                                                                    
                    node-role.kubernetes.io/master=                                                                                                                                                                                           
                    node.kubernetes.io/exclude-from-external-load-balancers=

ArangoGutierrez · 2021-11-12T15:27:58Z

ete-test using the test config file

Ran 3 of 230 Specs in 36.625 seconds                                                                                                                                                                                                          
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 227 Skipped                                                                                                                                                                                     
--- PASS: TestE2E (36.65s)                                                                                                                                                                                                                    
PASS                                                                                                                                                                                                                                          
ok      sigs.k8s.io/node-feature-discovery/test/e2e     36.681s

test

go test ./cmd/... ./pkg/... ./source/...                                                                                                                                                                                                      
?       sigs.k8s.io/node-feature-discovery/cmd/nfd-master       [no test files]                                                                                                                                                               
ok      sigs.k8s.io/node-feature-discovery/cmd/nfd-topology-updater     0.011s                                                                                                                                                                
ok      sigs.k8s.io/node-feature-discovery/cmd/nfd-worker       0.005s                                                                                                                                                                        
?       sigs.k8s.io/node-feature-discovery/pkg/api/feature      [no test files]                                                                                                                                                               
?       sigs.k8s.io/node-feature-discovery/pkg/apihelper        [no test files]                                                                                                                                                               
?       sigs.k8s.io/node-feature-discovery/pkg/cpuid    [no test files]                                                                                                                                                                       
ok      sigs.k8s.io/node-feature-discovery/pkg/kubeconf 0.015s                                                                                                                                                                                
?       sigs.k8s.io/node-feature-discovery/pkg/labeler  [no test files]                                                                                                                                                                       
?       sigs.k8s.io/node-feature-discovery/pkg/nfd-client       [no test files]                                                                                                                                                               
ok      sigs.k8s.io/node-feature-discovery/pkg/nfd-client/topology-updater      0.017s                                                                                                                                                        
ok      sigs.k8s.io/node-feature-discovery/pkg/nfd-client/worker        3.091s                                                                                                                                                                
ok      sigs.k8s.io/node-feature-discovery/pkg/nfd-master       0.019s                                                                                                                                                                        
?       sigs.k8s.io/node-feature-discovery/pkg/podres   [no test files]                                                                                                                                                                       
ok      sigs.k8s.io/node-feature-discovery/pkg/resourcemonitor  0.033s                                                                                                                                                                        
?       sigs.k8s.io/node-feature-discovery/pkg/topologypolicy   [no test files]                                                                                                                                                               
?       sigs.k8s.io/node-feature-discovery/pkg/topologyupdater  [no test files]                                                                                                                                                               
ok      sigs.k8s.io/node-feature-discovery/pkg/utils    0.040s                                                                                                                                                                                
?       sigs.k8s.io/node-feature-discovery/pkg/version  [no test files]                                                                                                                                                                       
ok      sigs.k8s.io/node-feature-discovery/source       0.004s                                                                                                                                                                                
ok      sigs.k8s.io/node-feature-discovery/source/cpu   0.005s                                                                                                                                                                                
ok      sigs.k8s.io/node-feature-discovery/source/custom        0.005s                                                                                                                                                                        
ok      sigs.k8s.io/node-feature-discovery/source/custom/expression     0.004s                                                                                                                                                                
?       sigs.k8s.io/node-feature-discovery/source/custom/rules  [no test files]                                                                                                                                                               
?       sigs.k8s.io/node-feature-discovery/source/fake  [no test files]                                                                                                                                                                       
?       sigs.k8s.io/node-feature-discovery/source/iommu [no test files]                                                                                                                                                                       
ok      sigs.k8s.io/node-feature-discovery/source/kernel        0.007s                                                                                                                                                                        
ok      sigs.k8s.io/node-feature-discovery/source/local 0.008s                                                                                                                                                                                
?       sigs.k8s.io/node-feature-discovery/source/memory        [no test files]                                                                                                                                                               
?       sigs.k8s.io/node-feature-discovery/source/network       [no test files]                                                                                                                                                               
ok      sigs.k8s.io/node-feature-discovery/source/pci   0.010s                                                                                                                                                                                
?       sigs.k8s.io/node-feature-discovery/source/storage       [no test files]                                                                                                                                                               
ok      sigs.k8s.io/node-feature-discovery/source/system        0.005s                                                                                                                                                                        
ok      sigs.k8s.io/node-feature-discovery/source/usb   0.005s

ArangoGutierrez · 2021-11-12T15:28:34Z

tested with quay.io/eduardoarango/node-feature-discovery:464

ArangoGutierrez · 2021-11-12T15:45:22Z

I think this PR is good to go, but to double check, lest all put eyes on @zvonkok

marquiz · 2021-11-12T15:49:32Z

I think this PR is good to go, but to double check, lest all put eyes on @zvonkok

Thanks for the review @ArangoGutierrez 👀
/unhold

zvonkok · 2021-11-16T13:01:04Z

As this PR does not consider the documentation we need to be aware to explicitly document the new API with some examples of matchFeatures and matchAny.

zvonkok · 2021-11-16T13:02:49Z

Tested several combinations of matchFeatures and matchAny, NFD produced the wanted labels:

                    feature.node.kubernetes.io/cpu-hardware_multithreading=true
                    feature.node.kubernetes.io/custom-cpu-AVX-AESNI-feature=true
                    feature.node.kubernetes.io/custom-wth-happens-here=false
                    feature.node.kubernetes.io/kernel-config.NO_HZ=true
                    feature.node.kubernetes.io/kernel-config.NO_HZ_FULL=true

zvonkok · 2021-11-16T13:02:54Z

/lgtm

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021

k8s-ci-robot requested review from ArangoGutierrez and zvonkok March 4, 2021 20:55

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2021

marquiz mentioned this pull request Mar 4, 2021

Add option to create "profiles" of feature labels. #456

Closed

marquiz force-pushed the devel/source-refactor branch from fce3173 to 542988c Compare March 4, 2021 21:03

marquiz force-pushed the devel/source-refactor branch from 542988c to 9f7496a Compare March 8, 2021 07:40

marquiz force-pushed the devel/source-refactor branch 3 times, most recently from dd57a37 to fd0080e Compare March 9, 2021 19:00

marquiz mentioned this pull request Mar 11, 2021

Detect and label CPU Model Name #270

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2021

marquiz force-pushed the devel/source-refactor branch from fd0080e to 69a6d66 Compare March 15, 2021 05:37

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2021

marquiz force-pushed the devel/source-refactor branch 2 times, most recently from 514ef2d to 2ebc7e3 Compare March 17, 2021 14:17

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2021

marquiz mentioned this pull request Apr 7, 2021

Allow specifying different label templates for different PCI devices #508

Closed

k8s-ci-robot assigned ArangoGutierrez Apr 20, 2021

marquiz force-pushed the devel/source-refactor branch from 2ebc7e3 to 87f2ff0 Compare April 22, 2021 04:44

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 22, 2021

marquiz mentioned this pull request Jun 10, 2021

feature to allow optionally setting taints based on node properties #540

Closed

marquiz force-pushed the devel/source-refactor branch 2 times, most recently from 8de67dc to fc5d2a7 Compare November 11, 2021 16:39

marquiz force-pushed the devel/source-refactor branch from fc5d2a7 to d4d71e4 Compare November 11, 2021 21:20

marquiz force-pushed the devel/source-refactor branch from d4d71e4 to 269f253 Compare November 12, 2021 14:43

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2021

marquiz added 3 commits November 12, 2021 16:51

source/custom: improved logging of expression matching

52d9aa2

Print out the result of applying an expression. Also, truncate the output to max 10 elements (of items matched against) unless '-v 4' verbosity level is in use.

marquiz force-pushed the devel/source-refactor branch from 269f253 to 52d9aa2 Compare November 12, 2021 14:52

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2021

mythi mentioned this pull request Nov 15, 2021

source/cpu: detect Intel SGX #647

Merged

marquiz mentioned this pull request Nov 15, 2021

source/storage: implement FeatureSource #649

Merged

k8s-ci-robot assigned zvonkok Nov 16, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021

k8s-ci-robot merged commit fd7c7e5 into kubernetes-sigs:master Nov 16, 2021

marquiz deleted the devel/source-refactor branch November 16, 2021 13:17

marquiz mentioned this pull request Nov 25, 2021

Add support to detect whether the node has storage #674

Closed

marquiz mentioned this pull request Dec 22, 2021

Release v0.10.0 #678

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More extensive and expressive custom rules #464

More extensive and expressive custom rules #464

marquiz commented Mar 4, 2021 •

edited

Loading

k8s-ci-robot commented Mar 4, 2021

k8s-ci-robot commented Mar 4, 2021

marquiz commented Mar 5, 2021

marquiz commented Mar 8, 2021

ArangoGutierrez commented Apr 20, 2021

marquiz commented Nov 11, 2021

marquiz commented Nov 11, 2021

marquiz commented Nov 11, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

marquiz commented Nov 12, 2021

zvonkok commented Nov 16, 2021

zvonkok commented Nov 16, 2021

zvonkok commented Nov 16, 2021

More extensive and expressive custom rules #464

More extensive and expressive custom rules #464

Conversation

marquiz commented Mar 4, 2021 • edited Loading

Overview

Rule syntax

Examples

matchAny

Notes

k8s-ci-robot commented Mar 4, 2021

k8s-ci-robot commented Mar 4, 2021

marquiz commented Mar 5, 2021

marquiz commented Mar 8, 2021

ArangoGutierrez commented Apr 20, 2021

marquiz commented Nov 11, 2021

marquiz commented Nov 11, 2021

marquiz commented Nov 11, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

ArangoGutierrez commented Nov 12, 2021

marquiz commented Nov 12, 2021

zvonkok commented Nov 16, 2021

zvonkok commented Nov 16, 2021

zvonkok commented Nov 16, 2021

marquiz commented Mar 4, 2021 •

edited

Loading