nfd-worker: add core.featureSources config option #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Makes more sense (and can be tested) when #604 has been merged. |
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
c36f86e
to
83aa356
Compare
|
Rebased |
k8s-ci-robot
removed
the
do-not-merge/hold
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
83aa356
to
626d5d1
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
626d5d1
to
a76b8bc
Compare
marquiz
changed the title
|
Renamed to |
|
/test all |
|
no need for rebase, hooray! |
ArangoGutierrez
requested changes
Nov 29, 2021
k8s-ci-robot
added
the
needs-rebase
|
@marquiz rebase 😁 |
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
a76b8bc
to
36ad649
Compare
k8s-ci-robot
removed
the
needs-rebase
Rebased. Plus I fixed some mistakes that I spotted myself |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign zvonkok |
|
Need to rebase and align this with #670 |
k8s-ci-robot
added
the
needs-rebase
Refactoring in head of adding new config option for feature sources.
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
36ad649
to
a8d57bb
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Rebased, I haven't verified this new rebase myself, though |
Verified that it works as expected |
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
a8d57bb
to
02f0364
Compare
|
Amended this PR with a new patch adding |
Add a configuration option for controlling the enabled "raw" feature sources. This is useful e.g. in testing and development, plus it also allows fully shutting down discovery of features that are not needed in a deployment. Supplements core.labelSources which controls the enablement of label sources.
Allows controlling (enable/disable) the "raw" feature detection. Especially useful for development and testing.
marquiz
force-pushed
the
devel/feature-source-config-flag
branch
from
02f0364
to
58e1461
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sources. This is useful e.g. in testing and development, plus it also
allows fully shutting down discovery of features that are not needed in
a deployment. Supplements core.labelSources which controls the
enablement of label sources.
-feature-sourcescommand line flagAllows controlling (enable/disable) the "raw" feature detection.
Especially useful for development and testing.