Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/fake: implement FeatureSource #692

Merged
merged 2 commits into from
Dec 7, 2021
Merged

source/fake: implement FeatureSource #692

merged 2 commits into from
Dec 7, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 3, 2021

Makes it possible to create fake features for custom rules, enabling
testing.

Depends on #605

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Dec 3, 2021

/assign @ArangoGutierrez

Pending on #605
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2021
@ArangoGutierrez
Copy link
Contributor

/assign @ArangoGutierrez

Pending on #605 /hold

Rebase?
/test all

@ArangoGutierrez
Copy link
Contributor

@marquiz this is ready IMO unhold?

ArangoGutierrez
ArangoGutierrez approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021
@marquiz
source/fake: drop stale Configure() method
969151e 
Also correct some comments.
@marquiz
source/fake: implement FeatureSource
82e1430 
Makes it possible to create fake features for custom rules, enabling
testing.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Dec 7, 2021

Rebase. #605 merged

@marquiz this is ready IMO unhold?

Yes

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2021
ArangoGutierrez
ArangoGutierrez approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit deabea8 into kubernetes-sigs:master Dec 7, 2021
@marquiz marquiz deleted the devel/fake-feature-source branch December 7, 2021 14:45
@marquiz marquiz mentioned this pull request Dec 22, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @ArangoGutierrez @k8s-ci-robot