-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source/cpu: detect Intel SGX #647
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
//go:build amd64 | ||
// +build amd64 | ||
|
||
/* | ||
Copyright 2021 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package cpu | ||
|
||
import ( | ||
"github.com/klauspost/cpuid/v2" | ||
) | ||
|
||
func discoverSGX() map[string]string { | ||
var epcSize uint64 | ||
sgx := make(map[string]string) | ||
|
||
if cpuid.CPU.SGX.Available { | ||
for _, s := range cpuid.CPU.SGX.EPCSections { | ||
epcSize += s.EPCSize | ||
} | ||
} | ||
|
||
// Set to 'true' based a non-zero sum value of SGX EPC section sizes. The | ||
// kernel checks for IA32_FEATURE_CONTROL.SGX_ENABLE MSR bit but we can't | ||
// do that as a normal user. Typically the BIOS, when enabling SGX, | ||
// allocates "Processor Reserved Memory" for SGX EPC so we rely on > 0 | ||
// size here to set "SGX = enabled". | ||
if epcSize > 0 { | ||
sgx["enabled"] = "true" | ||
} | ||
|
||
return sgx | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
//go:build !amd64 | ||
// +build !amd64 | ||
|
||
/* | ||
Copyright 2021 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package cpu | ||
|
||
func discoverSGX() map[string]string { | ||
return nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we advertise
epcSize
as the raw feature, directly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to start with something minimal/basic and
enabled
is consistent with the othercpu
source features. The boolean value can be taken intonodeSelector
directly which is my use case at least until #464 lands. Would there be any use forepcSize
other than using it in, e.g.,{op: Gt, value: ["0"]}
?I'm not sure how useful they are. We could label, e.g.,
sgx2=true
but to actually use the feature the kernel support needs to be there and we cannot detect that. max enclave size value is a bit value for2^(<value>)
computation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for the label
enabled
makes sense. I might be wrong but my intuition is that the better direction would be to expose "raw features" as raw as possible, avoiding any translations. More likely to avoid problems like the kernel module values (currently=y
and=m
now translate totrue
and we have no means of telling between y or m). As you said, in this caseenabled
would translate to{op: Gt, value: ["0"]}
in the custom rules. That said, I don't know what use people could find for the numerical value (expose it as an extended resource?). Maybe we should expose both,enabled
andepcSize
?K, can be added later, if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an NFD source hook to read
epcSize
and that value is registered assgx.intel.com/epc
. I guess NFD could register the value too but why not then use the NFD source hook because it comes with the device plugin that is also needed.