Return cluster-autoscaler-chart Chart name to cluster-autoscaler

[gjtempleton]

Fixes #3475

Update helm/chart-releaser action to leverage new functionality of the chart releaser action allowing custom overrides of the published chart artifact separate from the naming of the chart

Tested successfully on my fork here: https://github.com/gjtempleton/autoscaler/releases/tag/cluster-autoscaler-chart-2.0.0

This will keep the names of the build artifacts consistent with the existing ones for the 1.X.X releases of the chart, but update the naming in the published chart to be neater and consistent with best practices.

I've also included a note in the readme to warn users.

[llamahunter]

Yeah, that looks like it will do the trick. Many things in _helpers.tpl are driven off .Chart.Name, and so long as that is set the same as it was before migration from the legacy to new repo location, all the resources should not go through a destroy/create cycle.

Thx very much!

[llamahunter]

Hmm.. unclear if this should be 9.0.0 or something, tho. Since the last version was 8.0.0 before the chart took a detour through the other name.

[gjtempleton]

Yeah, that's a good point and would probably make migration from the deprecated chart easier on users.

I'll update this to 9.0.0 and update the docs to make clear why this is happening as well.

[stevehipwell]

@gjtempleton you could modify you checkout step to look like the following so you don't need a seperate fetch step.

- name: Checkout
  uses: actions/checkout@v2
  with:
    fetch-depth: 0

Also the example has a additional install helm step that may be required?

[stevehipwell]

@gjtempleton you could modify you checkout step to look like the following so you don't need a seperate fetch step.

- name: Checkout
  uses: actions/checkout@v2
  with:
    fetch-depth: 0

Also the example has a additional install helm step that may be required?

I can confirm that the additional helm step is required.

[stevehipwell]

Is there a roadmap for when this might be released?

[gjtempleton]

@stevehipwell I can't commit to a timeline as it'll need approval from one of the other repo owners

/assign @MaciekPytel

[llamahunter]

Thx for the update. Our upgrades to k8s 1.18 are sort of on hold until this gets merged.

[sc250024]

Thank you @gjtempleton !

[llamahunter]

still waiting on this

[stevehipwell]

The parallel kubernetes-sigs/descheduler#436 was merged yesterday if that helps?

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, llamahunter, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment