CA-Chart - Mark Cluster-Autoscaler-Chart as Deprecated #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
This was referenced Nov 25, 2020
gjtempleton
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Is this still needed/worked on? |
Perform major version bump of cluster-autoscaler-chart to mark it as deprecated in favour of cluster-autoscaler chart Make only change version number and deprecation notice
gjtempleton
force-pushed
the
cluster-autoscaler-chart-Chart-Deprecate-Final-Version
branch
from
0d9ef68
to
cf4e5db
Compare
k8s-ci-robot
added
size/XXL
gjtempleton
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Yep, had some discussions and the preference is for the option that makes this PR look rather messy unfortunately. I've updated the PR description to include instructions for seeing the changes from the last release of the chart as it used to be named here, the only meaningful changes being to bump the major version and mark the chart as deprecated. |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gjtempleton
deleted the
cluster-autoscaler-chart-Chart-Deprecate-Final-Version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a follow-up PR to remove these files as only one release marked as deprecated is required.
This diff looks very big, however this is due to copying back in the files for the
cluster-autoscaler-chartHelm chart as it was pre the renaming tocluster-autoscalerperformed by #3679 .The actual changes performed by this PR to the last previous release of the
cluster-autoscaler-chartchart marked by https://github.com/kubernetes/autoscaler/tree/cluster-autoscaler-chart-1.1.1 can be seen by runninggit diff cluster-autoscaler-chart-1.1.1 charts/cluster-autoscaler-chart/ diff --git a/charts/cluster-autoscaler-chart/Chart.yaml b/charts/cluster-autoscaler-chart/Chart.yaml index 4f86dcc4d..b288ae4a8 100644 --- a/charts/cluster-autoscaler-chart/Chart.yaml +++ b/charts/cluster-autoscaler-chart/Chart.yaml @@ -17,4 +17,5 @@ name: cluster-autoscaler-chart sources: - https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler type: application -version: 1.1.1 +version: 2.0.0 +deprecated: true diff --git a/charts/cluster-autoscaler-chart/README.md b/charts/cluster-autoscaler-chart/README.md ...The changes to the readme are expected as pre-commit hooks are now enforced and have regenerated the readme from the template.
Performs a major version bump of cluster-autoscaler-chart to mark it as deprecated
in favour of
cluster-autoscalerchartThis is required to hide the deprecated old version of the chart from the artifact hub UI, as currently users are shown both the old and new charts: https://artifacthub.io/packages/search?page=1&ts_query_web=cluster-autoscaler
Marking the chart as deprecated in the
Chart.yamlwill hide all releases of the old chart version from the UI. Performs a major version bump of the old version of the chart to 2.0.0 to mark the deprecation.