Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #357

Merged
merged 42 commits into from
May 12, 2022
Merged

Automated cherry pick of #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #357

merged 42 commits into from
May 12, 2022

Commits on May 11, 2022

  1. Add tagging controller configuration

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e7d899b View commit details
    Browse the repository at this point in the history

  2. add log

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9b9a1b7 View commit details
    Browse the repository at this point in the history

  3. rearrange the controllers

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    23e87a0 View commit details
    Browse the repository at this point in the history

  4. remove debugging log

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    07cd2d3 View commit details
    Browse the repository at this point in the history

  5. removed route controller

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    572c833 View commit details
    Browse the repository at this point in the history

  6. added a blank test file for the tagging controller

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    86a0822 View commit details
    Browse the repository at this point in the history

  7. remove predefined tag

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d720bf8 View commit details
    Browse the repository at this point in the history

  8. Refactoring based on recommendations

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9001cac View commit details
    Browse the repository at this point in the history

  9. Sticking to the naming convention

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    948239d View commit details
    Browse the repository at this point in the history

  10. address more comments on naming

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    08f6bd6 View commit details
    Browse the repository at this point in the history

  11. Using ListNode to get nodes entering and leaving the cluster. 

    * Remove route controller again

* Print out clusterName for new nodes

* tag new nodes when it comes online

* only process a node once

* check taggNodes size

* add debugging

* use node name as key

* delete k,v from taggedNodes if node no longer exists

* log if delete is done

* Get a list of nodes and tag them if havent

* get instance IDs of the nodes that need tagging

* use MapToAWSInstanceID instead

* restored v1 aws

* restored from master

* tag instance with a random tag

* add klog

* tag and untag node resources

* Prepare for pr

* Initialize nodeMap
    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e19546c View commit details
    Browse the repository at this point in the history

  12. refactor

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c934601 View commit details
    Browse the repository at this point in the history

  13. Add testing and controller config skeletons

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2563a4e View commit details
    Browse the repository at this point in the history

  14. Added tagging and flags mechanisms

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e3a440f View commit details
    Browse the repository at this point in the history

  15. Disabled the tagging controller by default

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9920964 View commit details
    Browse the repository at this point in the history

  16. Updated test structure

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a99c5ff View commit details
    Browse the repository at this point in the history

  17. Making the tests more robust

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    aaf415b View commit details
    Browse the repository at this point in the history

  18. Renaming the maps in tagging controller

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a3c7187 View commit details
    Browse the repository at this point in the history

  19. Refactoring names and remove debugging logs

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6315faa View commit details
    Browse the repository at this point in the history

  20. Add failure test cases for when EC2 return error

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8a007e1 View commit details
    Browse the repository at this point in the history

  21. adding details for --resources 

    * get user input for resources

* Add better testing for failures to add flags

* fix a small issue with --resources

* finalize the --resources
    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    44da07c View commit details
    Browse the repository at this point in the history

  22. add in Copyright message

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5515071 View commit details
    Browse the repository at this point in the history

  23. Using NodeInformer and Workqueue for tagging resources

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    967419f View commit details
    Browse the repository at this point in the history

  24. Used workqueue for both tag and untag actions

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9ab8c9d View commit details
    Browse the repository at this point in the history

  25. Update docs/tagging_controller.md 

    Co-authored-by: Nicholas Turner <1205393+nckturner@users.noreply.github.com>
    @nguyenkndinh @nckturner @saurav-agarwalla
    2 people authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1e88cf8 View commit details
    Browse the repository at this point in the history

  26. Renamed fields in the tagging controller to be more user friendly

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    29d8257 View commit details
    Browse the repository at this point in the history

  27. Added in a loop to make sure all messages are processed before shutti… 

    …ng down
    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3174f9e View commit details
    Browse the repository at this point in the history

  28. Added more logging

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e3ff5fd View commit details
    Browse the repository at this point in the history

  29. Added more testing

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7fa05e3 View commit details
    Browse the repository at this point in the history

  30. cosmetic change

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    151d4f9 View commit details
    Browse the repository at this point in the history

  31. use array instead of map for supported resources

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e48b6a2 View commit details
    Browse the repository at this point in the history

  32. Reworked the workqueue with workitem

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fcf3f37 View commit details
    Browse the repository at this point in the history

  33. Addressed comments

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    ace2f23 View commit details
    Browse the repository at this point in the history

  34. addressed verify-lint errors

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9b7c5fd View commit details
    Browse the repository at this point in the history

  35. addressed comments and verify-lint

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    26465b5 View commit details
    Browse the repository at this point in the history

  36. address validate-lint error

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7fe3719 View commit details
    Browse the repository at this point in the history

  37. missed a couple more lint errors

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e7adda9 View commit details
    Browse the repository at this point in the history

  38. Updated doc to be clearer

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c032318 View commit details
    Browse the repository at this point in the history

  39. Add TODOs for e2e testing and non-retryable workitem

    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c2ac277 View commit details
    Browse the repository at this point in the history

  40. Stop retrying failed workitem after a certain amount of retries Added… 

    … metrics
    @nguyenkndinh @saurav-agarwalla
    nguyenkndinh authored and saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    35c6d3c View commit details
    Browse the repository at this point in the history

  41. Sync Docker and Make files from master

    @saurav-agarwalla
    saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a102829 View commit details
    Browse the repository at this point in the history

  42. Changes to make tagging controller compatible with K8s 1.22

    @saurav-agarwalla
    saurav-agarwalla committed May 11, 2022
    Configuration menu
    Copy the full SHA
    56bd1cc View commit details
    Browse the repository at this point in the history