Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #357

Merged
merged 42 commits into from
May 12, 2022
Merged

Automated cherry pick of #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #357

merged 42 commits into from
May 12, 2022

Conversation

saurav-agarwalla
Copy link
Contributor

@saurav-agarwalla saurav-agarwalla commented May 11, 2022 •
edited by nckturner
Loading

Cherry pick of #308 #334 on release-1.22.

#308: Add tagging controller configuration
#334: Stop retrying failed workitem after a certain amount of

For details on the cherry pick process, see the cherry pick requests page.

NONE

nguyenkndinh and others added 30 commits May 11, 2022 15:52
@nguyenkndinh @saurav-agarwalla
Add tagging controller configuration
e7d899b
@nguyenkndinh @saurav-agarwalla
add log
9b9a1b7
@nguyenkndinh @saurav-agarwalla
rearrange the controllers
23e87a0
@nguyenkndinh @saurav-agarwalla
remove debugging log
07cd2d3
@nguyenkndinh @saurav-agarwalla
removed route controller
572c833
@nguyenkndinh @saurav-agarwalla
added a blank test file for the tagging controller
86a0822
@nguyenkndinh @saurav-agarwalla
remove predefined tag
d720bf8
@nguyenkndinh @saurav-agarwalla
Refactoring based on recommendations
9001cac
@nguyenkndinh @saurav-agarwalla
Sticking to the naming convention
948239d
@nguyenkndinh @saurav-agarwalla
address more comments on naming
08f6bd6
@nguyenkndinh @saurav-agarwalla
Using ListNode to get nodes entering and leaving the cluster.
e19546c 
* Remove route controller again

* Print out clusterName for new nodes

* tag new nodes when it comes online

* only process a node once

* check taggNodes size

* add debugging

* use node name as key

* delete k,v from taggedNodes if node no longer exists

* log if delete is done

* Get a list of nodes and tag them if havent

* get instance IDs of the nodes that need tagging

* use MapToAWSInstanceID instead

* restored v1 aws

* restored from master

* tag instance with a random tag

* add klog

* tag and untag node resources

* Prepare for pr

* Initialize nodeMap
@nguyenkndinh @saurav-agarwalla
refactor
c934601
@nguyenkndinh @saurav-agarwalla
Add testing and controller config skeletons
2563a4e
@nguyenkndinh @saurav-agarwalla
Added tagging and flags mechanisms
e3a440f
@nguyenkndinh @saurav-agarwalla
Disabled the tagging controller by default
9920964
@nguyenkndinh @saurav-agarwalla
Updated test structure
a99c5ff
@nguyenkndinh @saurav-agarwalla
Making the tests more robust
aaf415b
@nguyenkndinh @saurav-agarwalla
Renaming the maps in tagging controller
a3c7187
@nguyenkndinh @saurav-agarwalla
Refactoring names and remove debugging logs
6315faa
@nguyenkndinh @saurav-agarwalla
Add failure test cases for when EC2 return error
8a007e1
@nguyenkndinh @saurav-agarwalla
adding details for --resources
44da07c 
* get user input for resources

* Add better testing for failures to add flags

* fix a small issue with --resources

* finalize the --resources
@nguyenkndinh @saurav-agarwalla
add in Copyright message
5515071
@nguyenkndinh @saurav-agarwalla
Using NodeInformer and Workqueue for tagging resources
967419f
@nguyenkndinh @saurav-agarwalla
Used workqueue for both tag and untag actions
9ab8c9d
@nguyenkndinh @nckturner @saurav-agarwalla
Update docs/tagging_controller.md
1e88cf8 
Co-authored-by: Nicholas Turner <1205393+nckturner@users.noreply.github.com>
@nguyenkndinh @saurav-agarwalla
Renamed fields in the tagging controller to be more user friendly
29d8257
@nguyenkndinh @saurav-agarwalla
Added in a loop to make sure all messages are processed before shutti…
3174f9e 
…ng down
@nguyenkndinh @saurav-agarwalla
Added more logging
e3ff5fd
@nguyenkndinh @saurav-agarwalla
Added more testing
7fa05e3
@nguyenkndinh @saurav-agarwalla
cosmetic change
151d4f9
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

@saurav-agarwalla: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @saurav-agarwalla!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @saurav-agarwalla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saurav-agarwalla
To complete the pull request process, please assign nckturner after the PR has been reviewed.
You can assign the PR to them by writing /assign @nckturner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 11, 2022
@nckturner
Copy link
Contributor

/hold
After tests passing I'm going to squash and merge by hand, we accidentally merged this PR without squashing in master and its a nightmare.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 11, 2022
@nckturner nckturner merged commit da43499 into kubernetes:release-1.22 May 12, 2022
@saurav-agarwalla saurav-agarwalla deleted the automated-cherry-pick-of-#308-#334-upstream-release-1.22 branch June 22, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner Awaiting requested review from nckturner

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurav-agarwalla @k8s-ci-robot @nckturner @nguyenkndinh