Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport-1.31] [cinder-csi-plugin] Add --with-topology opt #2746

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[backport-1.31] [cinder-csi-plugin] Add --with-topology opt #2746

merged 1 commit into from
Dec 12, 2024

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

This is a manual backport of #2743
since the bot couldn't handle the heavy merge conflict.

Release note:

A new option, `--with-topology`, can be used to configure whether the driver and controller services of the `cinder-csi-plugin` report and respect topology information, respectively.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2024
@EmilienM
Copy link
Contributor Author

/assign stephenfin
for review

@EmilienM
Copy link
Contributor Author

I need to deal with missing sharedcsi package.

@stephenfin
Copy link
Member

/lgtm

Assuming CI is happy.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@stephenfin @EmilienM
cinder-csi-plugin: Add --with-topology option (kubernetes#2743)
ffe3ef1 
Many clouds do not have a 1:1 mapping of compute and storage AZs. As we
generate topology information from the metadata service on the node
(i.e. a compute AZ), this can prevent us from being able to schedule
VMs.

Add a new boolean, '--with-topology', to allow users to disable the
topology feature where it does not make sense. An identical option
already exists for the Manila CSI driver. However, unlike that option,
this one defaults to 'true' to retain current behavior.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
(cherry picked from commit ac23a1e)
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@stephenfin
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@EmilienM
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@EmilienM: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test openstack-cloud-controller-manager-e2e-test-release-131
  • /test openstack-cloud-csi-cinder-e2e-test-release-131
  • /test openstack-cloud-csi-cinder-sanity-test-release-131
  • /test openstack-cloud-csi-manila-e2e-test-release-131
  • /test openstack-cloud-csi-manila-sanity-test-release-131
  • /test openstack-cloud-keystone-authentication-authorization-test-release-131
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run the following jobs that were automatically triggered:

  • openstack-cloud-csi-cinder-e2e-test-release-131
  • openstack-cloud-csi-cinder-sanity-test-release-131
  • pull-cloud-provider-openstack-check
  • pull-cloud-provider-openstack-test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Contributor Author

/test openstack-cloud-controller-manager-e2e-test-release-131

1 similar comment
@EmilienM
Copy link
Contributor Author

/test openstack-cloud-controller-manager-e2e-test-release-131

@EmilienM
Copy link
Contributor Author

@kayrus when time permits, thanks

@kayrus
Copy link
Contributor

kayrus commented Dec 12, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6cb478d into kubernetes:release-1.31 Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus Awaiting requested review from kayrus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@stephenfin stephenfin

@kayrus kayrus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilienM @stephenfin @k8s-ci-robot @kayrus